Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working set 11 rolldown, with correct roll logic. #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sklimasz
Copy link
Owner

Correct roll logic to be consisent with game.
Remove headliner logic, game data from set 10.
Add data from set 11.

Copy link

Test Results

1 tests   - 5   1 ✅  - 5   22s ⏱️ -1s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 059a05b. ± Comparison against base commit 0a1f32f.

This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both.
roll_sim.tests.test_headliners ‑ test_bad_luck_rules
roll_sim.tests.test_headliners ‑ test_conf_headliners
roll_sim.tests.test_headliners ‑ test_conf_no_level
roll_sim.tests.test_headliners ‑ test_pool_depletion_easier
roll_sim.tests.test_headliners ‑ test_pool_depletion_harder
roll_sim.tests.test_headliners ‑ test_simple_rolldown
roll_sim.tests.test_rolldown ‑ test_rolldown_logic_with_math

Copy link

File Coverage
All files 66%
code/champion.py 92%
code/statistics.py 21%
code/utils.py 69%
scripts/rolldown.py 52%
scripts/rollorlvl.py 0%

Minimum allowed coverage is 66%

Generated by 🐒 cobertura-action against 059a05b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant