fix: add unique constraints on survey-taget table

skku-royals · Mar 14, 2024 · dc4754f · dc4754f
1 parent 7762466
commit dc4754f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/backend/app/src/survey/survey.service.ts b/backend/app/src/survey/survey.service.ts
@@ -3,6 +3,7 @@ import { RosterService } from '@/roster/roster.service'
 import { Service } from '@libs/decorator'
 import {
   BusinessException,
+  ConflictFoundException,
   EntityNotExistException,
   UnexpectedException
 } from '@libs/exception'
@@ -287,11 +288,11 @@ export class SurveyService {
       if (error instanceof BusinessException) {
         throw error
       }
-      if (
-        error instanceof Prisma.PrismaClientKnownRequestError &&
-        error.code === 'P2025'
-      ) {
-        throw new EntityNotExistException('출석조사 대상이 아닙니다')
+      if (error instanceof Prisma.PrismaClientKnownRequestError) {
+        if (error.code === 'P2003')
+          throw new ConflictFoundException('이미 제출하였습니다')
+        if (error.code === 'P2025')
+          throw new EntityNotExistException('출석조사 대상이 아닙니다')
       }
       throw new UnexpectedException(error)
     }

diff --git a/...rations/20240310055854_init/migration.sql → ...rations/20240314110508_init/migration.sql b/...rations/20240310055854_init/migration.sql → ...rations/20240314110508_init/migration.sql
@@ -107,9 +107,7 @@ CREATE TABLE "surveyGroup" (
 CREATE TABLE "surveyTarget" (
     "roster_id" INTEGER NOT NULL,
     "survey_group_id" INTEGER NOT NULL,
-    "submit" BOOLEAN NOT NULL DEFAULT false,
-
-    CONSTRAINT "surveyTarget_pkey" PRIMARY KEY ("roster_id","survey_group_id")
+    "submit" BOOLEAN NOT NULL DEFAULT false
 );
 
 -- CreateTable
@@ -174,6 +172,9 @@ CREATE UNIQUE INDEX "user_email_key" ON "user"("email");
 -- CreateIndex
 CREATE UNIQUE INDEX "roster_student_id_key" ON "roster"("student_id");
 
+-- CreateIndex
+CREATE UNIQUE INDEX "surveyTarget_roster_id_survey_group_id_key" ON "surveyTarget"("roster_id", "survey_group_id");
+
 -- AddForeignKey
 ALTER TABLE "roster" ADD CONSTRAINT "roster_user_id_fkey" FOREIGN KEY ("user_id") REFERENCES "user"("id") ON DELETE SET NULL ON UPDATE CASCADE;
 

diff --git a/backend/prisma/schema.prisma b/backend/prisma/schema.prisma
@@ -167,7 +167,7 @@ model SurveyTarget {
   Roster      Roster      @relation(fields: [rosterId], references: [id], onDelete: Cascade)
   SurveyGroup SurveyGroup @relation(fields: [surveyGroupId], references: [id], onDelete: Cascade)
 
-  @@id([rosterId, surveyGroupId])
+  @@unique([rosterId, surveyGroupId])
   @@map("surveyTarget")
 }