Use correct request namespace when creating ServiceMonitors

Use "openshiftMonitoringNS" instead of "ns" when first attempting to create in the former namespace. Signed-off-by: Tom Pantelis <[email protected]>
skitt · May 7, 2024 · d191623 · d191623
1 parent 626f4e8
commit d191623
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/metrics/service-monitor.go b/pkg/metrics/service-monitor.go
@@ -62,7 +62,8 @@ func CreateServiceMonitors(ctx context.Context, config *rest.Config, ns string,
 
 		// On OpenShift, we need to create the service monitors in the OpenShift monitoring namespace, not the
 		// service's. If that namespace doesn't exist then create in the provided namespace.
-		smc, err := mclient.ServiceMonitors(ns).Create(ctx, GenerateServiceMonitor(openshiftMonitoringNS, s), metav1.CreateOptions{})
+		smc, err := mclient.ServiceMonitors(openshiftMonitoringNS).Create(ctx, GenerateServiceMonitor(openshiftMonitoringNS, s),
+			metav1.CreateOptions{})
 
 		missingNS, _ := resource.IsMissingNamespaceErr(err)
 		if missingNS {