Skip to content

Commit

Permalink
Retry when export a not supported type service
Browse files Browse the repository at this point in the history
When a ServiceExport point to a service which type is
not supported in ServiceImport,we need to requeue.
the service may change to a ServiceImport support type.

When the service type change to a supported type,
ServiceImport need to create.

Fixes submariner-io#875
Signed-off-by: blue-troy <12729455+blue-troy@users.noreply.github.com>
  • Loading branch information
blue-troy authored and nyechiel committed Sep 19, 2022
1 parent e6057f4 commit 864035d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/agent/controller/agent.go
Original file line number Diff line number Diff line change
@@ -273,7 +273,7 @@ func (a *Controller) serviceExportToServiceImport(obj runtime.Object, numRequeue
fmt.Sprintf("Service of type %v not supported", svc.Spec.Type))
klog.Errorf("Service type %q not supported", svc.Spec.Type)

return nil, false
return nil, true
}

serviceImport := a.newServiceImport(svcExport.Name, svcExport.Namespace)

0 comments on commit 864035d

Please sign in to comment.