Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example link and some typo in Readme #605

Merged
merged 10 commits into from
Nov 26, 2024

Conversation

khafatech
Copy link
Contributor

The examples link was wrong, and I fixed minor typo & punctuation in the sentence about SkimItemReader

@LoricAndre
Copy link
Contributor

Could you also change the old repository url to the new org please ?

@khafatech
Copy link
Contributor Author

@LoricAndre Good catch! I updated the url to this repository

README.md Outdated Show resolved Hide resolved
@LoricAndre
Copy link
Contributor

Have you proofread the rest of the README ? I'd like to avoid merging a PR this small if we can

@khafatech
Copy link
Contributor Author

Have you proofread the rest of the README ? I'd like to avoid merging a PR this small if we can

I haven't. Good idea, I'll proof read the rest of the readme and add a new commit

khafatech and others added 6 commits November 23, 2024 14:43
…im-rs#413)

Also,

- Use the Github API to download the latest `version`
- Use the new release artefact format
- Fix grep pattern to work across Mac / Linux
- Fix version check to strip out `sk` prefix
- Exit when existing version already matches

This allows the install script to work with Raspbian running on a
Raspberry Pi
* chore: remove some platform-specific quirkinesses from e2e

* debug

* Revert "debug"

This reverts commit ed065c3.

---------

Co-authored-by: LoricAndre <[email protected]>
@LoricAndre LoricAndre merged commit 4b4795e into skim-rs:master Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants