-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example link and some typo in Readme #605
Merged
Merged
+42
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could you also change the old repository url to the new org please ? |
@LoricAndre Good catch! I updated the url to this repository |
LoricAndre
reviewed
Nov 22, 2024
Have you proofread the rest of the README ? I'd like to avoid merging a PR this small if we can |
I haven't. Good idea, I'll proof read the rest of the readme and add a new commit |
…im-rs#413) Also, - Use the Github API to download the latest `version` - Use the new release artefact format - Fix grep pattern to work across Mac / Linux - Fix version check to strip out `sk` prefix - Exit when existing version already matches This allows the install script to work with Raspbian running on a Raspberry Pi
* chore: remove some platform-specific quirkinesses from e2e * debug * Revert "debug" This reverts commit ed065c3. --------- Co-authored-by: LoricAndre <[email protected]>
LoricAndre
force-pushed
the
master
branch
3 times, most recently
from
November 26, 2024 17:01
6b0fab9
to
e649d08
Compare
LoricAndre
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The examples link was wrong, and I fixed minor typo & punctuation in the sentence about
SkimItemReader