-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of preview callback #407
base: master
Are you sure you want to change the base?
Conversation
Hey @lotabout, could you please take a look at this PR and see if you want to merge it? I'm not sure why it's failing on one test, I'm happy to fix it if you could give me a hint. Alex. |
Interesting, but does it allow for pre-processing of entry before handing it to preview command. In my case I have paths that I abbreviated and I have a rust function that perform some adjustment to make absolute path again. Then I'd pass it to |
If you want to pre-precess before sending to |
Thanks @alexxbb I'll drop preview requirement for the moment. |
6b0fab9
to
e649d08
Compare
This looks really interesting, I might try to pick it up and complete it. |
The preview feature of skim is great, however when skim is used as a library, there's no way to render a preview from Rust code.
This PR adds a new option to SkimOptionsBuilder:
The closure will be called with the currently selected items to render.