Skip to content

Commit

Permalink
Fix jest preprocessor script
Browse files Browse the repository at this point in the history
Summary:
Related to facebook#3999

There is an issue with the `preprocessor` script when using node >=5 as it uses npm 3. ~~There are (at least) two solutions, (I'm submitting the first one):~~
- ~~specify min required node version to 5.x and modify [this the preprocessor script](https://github.com/facebook/react-native/blob/0.16-stable/jestSupport/preprocessor.js#L29) to match npm 3 requirements~~
- ~~specifify node version >= 4.x and < 5.x and let the preprocessor script as it is~~

**EDIT**:
Using `require.resolve` will do the trick !

--
Thank you guys for this amazing project by the way ;)
Closes facebook#4903

Reviewed By: svcscm

Differential Revision: D2838759

Pulled By: androidtrunkagent

fb-gh-sync-id: ebb12f225a519ea23afc4f013bb063a920193719
  • Loading branch information
ahanriat authored and Tj committed Jan 21, 2016
1 parent a64de67 commit c48b184
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion jestSupport/preprocessor.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,6 @@ module.exports = {
getCacheKey: createCacheKeyFunction([
__filename,
path.join(__dirname, '../packager/transformer.js'),
path.join(__dirname, '../node_modules/babel-core/package.json'),
require.resolve('babel-core/package.json'),
]),
};

0 comments on commit c48b184

Please sign in to comment.