Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i have replace the specific discussion link with common discussion link #43

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

ranadip01in
Copy link
Contributor

@ranadip01in ranadip01in commented Aug 21, 2023

Summary

As per needed two specific discussion link has been replace with common discussion link

Changes

-- README.md
-- .github > steps > X-finish.md
discussion links has been replaces with required one

Closes: #42 (comment)

I will open PRs to apply this change to the courses.

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

@cmwilson21
Copy link

cmwilson21 commented Aug 21, 2023

@ranadip01in Thanks for picking this up! 🎉

We are looking to be a bit more specific with the links. If you look on the left hand side of the discussions page, you can see that each course has it's own category. That's the link we are hoping to update this course to.

So, would you mind updating your PR and linking to https://github.com/orgs/skills/discussions/categories/review-pull-requests instead? ✨

Also, I've edited your PR slightly to link to the link to the issue. For it to link correctly, the issue you are closing needs to be on the same line as the key word "Closes:" 👍

Copy link

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmwilson21
Copy link

@ranadip01in Thanks for submitting this PR with the link update! I'll get this merged down! 🎉

@cmwilson21 cmwilson21 merged commit 86bb43a into skills:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update discussions link
2 participants