Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile for proper integration of git hooks script #67

Merged
merged 7 commits into from
Apr 10, 2019

Conversation

davidferlay
Copy link
Contributor

Observed result

  • Newly added Makefile instructions are executed for every make .. command
$(info Installing git hooks)
$(shell ln -sfn ../../scripts/git_hooks/pre-commit.sh .git/hooks/pre-commit)

Expected result

  • Creation of script symbolic link should not happen at every make .. command
  • A new make .. command could be useful for developer to run script (like it's possible for phpcs for ex)

Todo

  • Move symlink creation to `make hooksymlink``
  • Add make hooksymlink to make all
  • Create another make command make hookexec to just run git hook script itself

@davidferlay davidferlay requested a review from andypost April 3, 2019 15:57
Copy link
Contributor

@andypost andypost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use make ability to detect changes to run action

Makefile Show resolved Hide resolved
David Ferlay added 2 commits April 9, 2019 10:16
commit 78b88e98eb36458e3d89115d236b2170910aeb3a
Author: David Ferlay <[email protected]>
Date:   Mon Apr 8 19:37:50 2019 +0200

commit 160a6bb79a34efcd65bb4ffdd4e3d8efe17b8d06
Author: David Ferlay <[email protected]>
Date:   Wed Apr 3 17:48:30 2019 +0200
@davidferlay davidferlay force-pushed the pre-commit-hook-config-lang branch from 802ec68 to 7f45423 Compare April 9, 2019 08:43
@jbguerraz
Copy link
Member

follow-up #70

@jbguerraz jbguerraz merged commit 6bfceb4 into skilld-labs:master Apr 10, 2019
@davidferlay davidferlay deleted the pre-commit-hook-config-lang branch May 15, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants