Adding static storybook to CI #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidferlay
requested changes
Dec 18, 2019
davidferlay
reviewed
Dec 19, 2019
scripts/makefile/front.mk
Outdated
| @@ -55,4 +54,4 @@ storybook: | |||
| @echo "Running storybook..." | |||
| docker pull $(IMAGE_FRONT) | |||
| $(call frontexec, yarn install --ignore-optional --check-files) | |||
| $(call frontexec, yarn storybook -p $(FRONT_PORT)) | |||
| $(call frontexec, yarn build-storybook --verbose) | |||
There was a problem hiding this comment.
++
I guess global todo is :
Update existingDonemake storybookcommand to generate static files (https://github.com/skilld-labs/skilld-docker-container/blob/195-add-static-storybook/scripts/makefile/front.mk#L53)- Add
make storybookto list of job inmake all_ci(https://github.com/skilld-labs/skilld-docker-container/blob/195-add-static-storybook/Makefile#L35) - Add a few commands to
.deploy_template: &deploy_template(https://github.com/skilld-labs/skilld-docker-container/blob/195-add-static-storybook/.gitlab-ci.yml#L148), at the end ofscriptpart with goal to move storybook static files in a dir inside web/ (like it is done here https://github.com/skilld-labs/skilld-docker-container/blob/195-add-static-storybook/.gitlab-ci.yml#L220-L223)
That way, generating static storybook will be part of RA job and everything remains clean.
Is it ok for you ?
There was a problem hiding this comment.
@davidferlay, @andypost Have another vision
hog-seruj
force-pushed
the
195-add-static-storybook
branch
from
a036599 to
0fddbf1
Compare
iberdinsky-skilld
force-pushed
the
195-add-static-storybook
branch
from
0fddbf1 to
3f03960
Compare
|
davidferlay
force-pushed
the
195-add-static-storybook
branch
from
b3258dd to
35ebfe9
Compare
davidferlay
changed the title
davidferlay
approved these changes
Mar 4, 2020
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.