Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of front processes #108

Merged
merged 5 commits into from
Dec 4, 2019
Merged

Rework of front processes #108

merged 5 commits into from
Dec 4, 2019

Conversation

iberdinsky-skilld
Copy link
Contributor

Closes #107

Updated front tasks.

  • No more specific front image. It is not universal and became outdated very fast.
  • CI tasks use artifacts and cache to save build time.
  • On local machines it is still possible to use docker make front with available option to keep /node_modules stored locally to speed up next builds.
  • Added readme notes about ^ changes
  • Added (tested) storybook task. It can be useful in next processes changes.
  • Changed order of scripts/front.mk inclusion. since it had no access to .env variables

.gitlab-ci.yml Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
scripts/makefile/front.mk Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
@davidferlay davidferlay changed the title rework of front processes. Rework of front processes Aug 6, 2019
@koskinpark koskinpark force-pushed the front_rework branch 2 times, most recently from 7e1de54 to d92733e Compare November 12, 2019 08:19
Copy link
Contributor

@andypost andypost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should stop using node:lts and create new frontend image for reason of compatibility

.env.default Show resolved Hide resolved
Makefile Show resolved Hide resolved
@andypost
Copy link
Contributor

Here should be split in CI jobs

  • Build node modules for run (cachable somehow) to execute lint, build, release
  • Jobs to scan build stack for updates and security

Copy link
Contributor

@andypost andypost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, we could add it to ci as well

@davidferlay davidferlay merged commit 4533e72 into master Dec 4, 2019
@andypost andypost deleted the front_rework branch May 5, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework of gitlab ci and make front tasks.
6 participants