Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include file removal in resource bump, Dry-run option with standard bump #63

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

iignatevich
Copy link
Collaborator

No description provided.

@davidferlay
Copy link
Contributor

davidferlay commented Nov 26, 2024

Does not seem to execute bump anymore:

➜ echo " " >> interaction/softwares/roles/nexus/templates/Dockerfile.j2 && git add -A && git commit -m "test"                       
[testdff 0ec7367182] QSD                                                                                                                
 1 file changed, 1 insertion(+)

➜ ./plasmactl bump --dry-run                                                                                
 INFO  Bumping updated resources...
 INFO  No resource to update

➜ ./plasmactl bump          
 INFO  Bumping updated resources...
 INFO  No resource to update

➜ pl bump                                                                   
 INFO  Bumping updated resources...  
Processing resource interaction__softwares__nexus
Updating versions:
- interaction__softwares__nexus from 9597a65e69f5e to 0ec7367182369
Commit changes to updated resources

works for deletion though:

➜ rm interaction/applications/roles/academy/templates/manifests.yaml.j2 
➜ git add -A     
➜ git commit -m "commit removal of file in some resource" 
[testdff ee4e7e328a] commit removal of file in some resource
 1 file changed, 149 deletions(-)
 delete mode 100644 interaction/applications/roles/academy/templates/manifests.yaml.j2
 
➜ ./plasmactl bump                                                      
 INFO  Bumping updated resources...
Processing resource interaction__applications__academy
Updating versions:
- interaction__applications__academy from e100e54ff6e1e to ee4e7e328a154
Commit changes to updated resources

@iignatevich iignatevich force-pushed the 59-include-file-removal-in-resource-bump branch from bf9d2c6 to bbdd3a1 Compare November 26, 2024 15:24
@davidferlay davidferlay marked this pull request as ready for review November 26, 2024 15:42
@davidferlay davidferlay merged commit 767ecf5 into main Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants