modified exact_bias32
to use omp parallel for reduction
#11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simplified the
exact_bias32
implementation usingomp parallel for reduction
instead of doing the reduction manually.I haven't tested this extensively, but I did compare two complete
./prospector -e -E -4 -l tests/murmurhash3_finalizer32.so
runs and found thatomp parallel for reduction
was a bit faster (original:~3 ns / hash
vs new:~2.8 ns / hash
).Note that the array reduction feature was added in OpenMP 4.5, which was released in 2016, so it might be too new to warrant the change.