Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified exact_bias32 to use omp parallel for reduction #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

camel-cdr
Copy link

@camel-cdr camel-cdr commented Apr 14, 2021

I simplified the exact_bias32 implementation using omp parallel for reduction instead of doing the reduction manually.

I haven't tested this extensively, but I did compare two complete ./prospector -e -E -4 -l tests/murmurhash3_finalizer32.so runs and found that omp parallel for reduction was a bit faster (original:~3 ns / hash vs new: ~2.8 ns / hash).

Note that the array reduction feature was added in OpenMP 4.5, which was released in 2016, so it might be too new to warrant the change.

@skeeto
Copy link
Owner

skeeto commented Apr 24, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants