Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22682] TripKitUI submodule and all modules inside refactoring #478

Merged
merged 26 commits into from
Dec 3, 2024

Conversation

MichaelReyes
Copy link
Collaborator

Pull Request (PR) Checklist

Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use [x] to check a box, e.g., [x], and make sure there's no space around the brackets.

PR Context

Changes

Describe your changes in detail, highlighting the problem it solves or the feature it adds.

  • [TripKit] convert GCAppResultInterface.java to kotlin
  • [TripKit] convert GCBoundingBox.java to kotlin
  • [TripKit] convert GCBoundingBoxInterface.java to kotlin
  • [TripKit] convert GCFoursquareResultInterface.java to kotlin
  • [TripKit] convert GCGoogleResultInterface.java to kotlin
  • [TripKit] convert GCQueryInterface.java to kotlin
  • [TripKit] convert GCResult.java to kotlin
  • [TripKit] convert GCResultInterface.java to kotlin
  • [TripKit] convert GCSkedGoResultInterface.java to kotlin
  • [TripKit] convert GeocodeUtilities.java to kotlin
  • [TripKit] convert GroupScoringResult.java to kotlin
  • [TripKit] convert MGAResultInterface.java to kotlin
  • [TripKit] convert MultiSourceGeocodingAggregator.java to kotlin
  • [TripKit] convert ScoringResult.java to kotlin
  • [TripKitUI] convert AppResultLocationAdapter.java to kotlin
  • [TripKitUI] convert FoursquareResultLocationAdapter.java to kotlin
  • [TripKitUI] convert GoogleResultLocationAdapter.java to kotlin
  • [TripKitUI] convert SkedgoResultLocationAdapter.java to kotlin
  • [TripKit] convert A2bRoutingApi.java to kotlin
  • [TripKit] convert FailoverA2bRoutingApi.java to kotlin
  • [TripKit] convert GCAppResult.java to kotlin
  • [TripKit] convert GCFoursquareResult.java to kotlin
  • [TripKit] convert GCGoogleResult.java to kotlin
  • [TripKit] convert GCQuery.java to kotlin
  • [TripKit] convert GCSkedgoResult.java to kotlin
  • [TripKit] convert LatLng.java to kotlin
  • [TripGov5] ODIN specific fixes for the updated TripGoActionButtonHandler class on other WL
  • [TripKit] convert AlertBlock.java to kotlin
  • [TripKit] convert ModeInfo.java to kotlin
  • [TripKit] convert RealtimeAlertApi.java to kotlin
  • [TripKit] convert RealtimeAlertResponse.java to kotlin
  • [TripKit] convert RealtimeAlertService.java to kotlin
  • [TripKit] convert Route.java to kotlin
  • [TripKit] convert BookingProvider.java to kotlin
  • [TripKit] convert BookingResolver.java to kotlin
  • [TripKit] convert BookingResolverImpl.java to kotlin
  • [TripKit] convert FlitWaysBookingResolver.java to kotlin
  • [TripKit] convert GoCatchBookingResolver.java to kotlin
  • [TripKit] convert IngogoBookingResolver.java to kotlin
  • [TripKit] convert LyftBookingResolver.java to kotlin
  • [TripKit] convert SmsBookingResolver.java to kotlin
  • [TripKit] convert TelBookingResolver.java to kotlin
  • [TripKit] convert WebBookingResolver.java to kotlin
  • [TripKit] convert ExtensionScope.java to kotlin
  • [TripKit] convert ExtraQueryMapProvider.java to kotlin
  • [TripKit] convert RegionInfoApi.java to kotlin
  • [TripKit] convert RegionInfoBody.java to kotlin
  • [TripKit] convert RegionInfoResponse.java to kotlin
  • [TripKit] convert RegionInfoService.java to kotlin
  • [TripKit] convert TspModule.java to kotlin
  • [TripKit] convert BaseUrlOverridingInterceptor.java to kotlin
  • [TripKit] convert BookingAction.java to kotlin
  • [TripKit] convert Cache.java to kotlin
  • [TripKit] convert CarPark.java to kotlin
  • [TripKit] convert Co2Preferences.java to kotlin
  • [TripKit] convert CursorToRegionConverter.java to kotlin
  • [TripKit] convert CursorToTransportModeConverter.java to kotlin
  • [TripKit] convert DataLoader.java to kotlin
  • [TripKit] convert DefaultCo2Preferences.java to kotlin
  • [TripKit] convert ExternalActionParams.java to kotlin
  • [TripKit] convert LineSegment.java to kotlin
  • [TripKit] convert LocationInfo.java to kotlin
  • [TripKit] convert LocationInfoApi.java to kotlin
  • [TripKit] convert LocationInfoDetails.java to kotlin
  • [TripKit] convert LocationInfoService.java to kotlin
  • [TripKit] convert LocationInfoServiceImpl.java to kotlin
  • [TripKit] convert MainModule.java to kotlin
  • [TripKit] convert RegionDatabaseHelper.java to kotlin
  • [TripKit] convert RegionFinder.java to kotlin
  • [TripKit] convert RegionsApi.java to kotlin
  • [TripKit] convert ServiceApi.java to kotlin

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: Are all changes, new functionalities, and classes documented with KDocs?
  • Architectural Patterns: Is there consistent and proper use of architectural patterns (e.g., MVVM, MVP)?

Testing and Reliability

  • Unit Testing: Are there unit tests for all new functionalities and classes?
  • Emulator and Real Device Testing: Has the application been tested on both emulators and real devices to ensure compatibility?

Error Handling and Logging

  • Error Handling: Are errors and exceptions caught and handled gracefully, ensuring the app remains stable?
  • Logging: Is there proper logging in place for critical errors and information, aiding in debugging and monitoring?

Testing Procedure

If applicable, provide steps or commands for testing your changes. This can help reviewers and testers.

Work-in-Progress (WIP)

List any remaining work or areas that need additional focus. This section can be updated as the work progresses.

  • [ ]
  • [ ]

Remember to keep this template updated based on the feedback and evolving project standards.

- [TripKit] convert GCAppResultInterface.java to kotlin
- [TripKit] convert GCBoundingBox.java to kotlin
- [TripKit] convert GCBoundingBoxInterface.java to kotlin
- [TripKit] convert GCFoursquareResultInterface.java to kotlin
- [TripKit] convert GCGoogleResultInterface.java to kotlin
- [TripKit] convert GCQueryInterface.java to kotlin
- [TripKit] convert GCResult.java to kotlin
- [TripKit] convert GCResultInterface.java to kotlin
- [TripKit] convert GCSkedGoResultInterface.java to kotlin
- [TripKit] convert GeocodeUtilities.java to kotlin
- [TripKit] convert GroupScoringResult.java to kotlin
- [TripKit] convert MGAResultInterface.java to kotlin
- [TripKit] convert MultiSourceGeocodingAggregator.java to kotlin
- [TripKit] convert ScoringResult.java to kotlin
- [TripKitUI] convert AppResultLocationAdapter.java to kotlin
- [TripKitUI] convert FoursquareResultLocationAdapter.java to kotlin
- [TripKitUI] convert GoogleResultLocationAdapter.java to kotlin
- [TripKitUI] convert SkedgoResultLocationAdapter.java to kotlin
- [TripKit] convert A2bRoutingApi.java to kotlin
- [TripKit] convert FailoverA2bRoutingApi.java to kotlin
- [TripKit] convert GCAppResult.java to kotlin
- [TripKit] convert GCFoursquareResult.java to kotlin
- [TripKit] convert GCGoogleResult.java to kotlin
- [TripKit] convert GCQuery.java to kotlin
- [TripKit] convert GCSkedgoResult.java to kotlin
- [TripKit] convert LatLng.java to kotlin
- [TripGov5] ODIN specific fixes for the updated TripGoActionButtonHandler class on other WL
- [TripKit] convert AlertBlock.java to kotlin
- [TripKit] convert ModeInfo.java to kotlin
- [TripKit] convert RealtimeAlertApi.java to kotlin
- [TripKit] convert RealtimeAlertResponse.java to kotlin
- [TripKit] convert RealtimeAlertService.java to kotlin
- [TripKit] convert Route.java to kotlin
- [TripKit] convert BookingProvider.java to kotlin
- [TripKit] convert BookingResolver.java to kotlin
- [TripKit] convert BookingResolverImpl.java to kotlin
- [TripKit] convert FlitWaysBookingResolver.java to kotlin
- [TripKit] convert GoCatchBookingResolver.java to kotlin
- [TripKit] convert IngogoBookingResolver.java to kotlin
- [TripKit] convert LyftBookingResolver.java to kotlin
- [TripKit] convert SmsBookingResolver.java to kotlin
- [TripKit] convert TelBookingResolver.java to kotlin
- [TripKit] convert WebBookingResolver.java to kotlin
- [TripKit] convert ExtensionScope.java to kotlin
- [TripKit] convert ExtraQueryMapProvider.java to kotlin
- [TripKit] convert RegionInfoApi.java to kotlin
- [TripKit] convert RegionInfoBody.java to kotlin
- [TripKit] convert RegionInfoResponse.java to kotlin
- [TripKit] convert RegionInfoService.java to kotlin
- [TripKit] convert TspModule.java to kotlin
- [TripKit] convert BaseUrlOverridingInterceptor.java to kotlin
- [TripKit] convert BookingAction.java to kotlin
- [TripKit] convert Cache.java to kotlin
- [TripKit] convert CarPark.java to kotlin
- [TripKit] convert Co2Preferences.java to kotlin
- [TripKit] convert CursorToRegionConverter.java to kotlin
- [TripKit] convert CursorToTransportModeConverter.java to kotlin
- [TripKit] convert DataLoader.java to kotlin
- [TripKit] convert DefaultCo2Preferences.java to kotlin
- [TripKit] convert ExternalActionParams.java to kotlin
- [TripKit] convert LineSegment.java to kotlin
- [TripKit] convert LocationInfo.java to kotlin
- [TripKit] convert LocationInfoApi.java to kotlin
- [TripKit] convert LocationInfoDetails.java to kotlin
- [TripKit] convert LocationInfoService.java to kotlin
- [TripKit] convert LocationInfoServiceImpl.java to kotlin
- [TripKit] convert MainModule.java to kotlin
- [TripKit] convert RegionDatabaseHelper.java to kotlin
- [TripKit] convert RegionFinder.java to kotlin
- [TripKit] convert RegionsApi.java to kotlin
- [TripKit] convert ServiceApi.java to kotlin
- [TripKit] convert ModeCombinationStrategy.java to kotlin
- [TripKit] convert OnSubscribeLoadRegions.java to kotlin
- [TripKit] convert OnSubscribeLoadTransportModes.java to kotlin
- [TripKit] convert OnSubscribeSaveRegionsResponse.java to kotlin
- [TripKit] convert OutOfRegionsException.java to kotlin
- [TripKit] convert PeriodicRealTimeTripUpdateReceiver.java to kotlin
- [TripKit] convert RealTimeTripUpdateReceiver.java to kotlin
- [TripKit] convert ServiceExtras.java to kotlin
- [TripKit] convert Tables.java to kotlin
- [TripKit] convert TemporaryUrlApi.java to kotlin
- [TripKit] convert TransitService.java to kotlin
- [TripKit] convert TripKit.java to kotlin
- [TripKit] convert TripKitConfigs.java to kotlin
- [TripKit] convert TripPreferences.java to kotlin
- [TripKit] convert Utils.java to kotlin
- [TripKit] convert UuidProvider.java to kotlin
- [TripKitUI] update affected classes
- [TripGov5] update affected classes
- [TripKit] convert AndroidGeocoderTest.java to kotlin
- [TripKit] convert RegionDatabaseHelperTest.java to kotlin
- [TripKit] re-enable, convert and update BookingResolverImplTest.java to kotlin
- [TripKit] convert, fix and update RealtimeAlertApiTest.java to kotlin
- [TripKit] convert, fix and update RealtimeAlertServiceTest.java to kotlin
- [TripKit] convert, fix and update RegionInfoApiTest.java to kotlin
- [TripKit] convert, fix and update RegionInfoServiceTest.java to kotlin
- [TripKit] convert, fix and update RouteServiceImplTest.java to kotlin
- [TripKit] convert, fix and update SelectBestDisplayTripTest.java to kotlin
- [TripKit] convert, fix and update SmsBookingResolverTest.java to kotlin
- [TripKit] re-enable and fix UberBookingResolverTest.kt
- [TripKit] convert, fix and update UtilsTest.java to kotlin
- [TripKit] convert, fix and update BaseUrlOverridingInterceptorTest.java to kotlin
- [TripKit] convert, fix and update DataLoaderTest.java to kotlin
- [TripKit] convert, fix and update DefaultCo2PreferencesTest.java to kotlin
- [TripKit] convert, fix and update DefaultTripPreferencesTest.java to kotlin
- [TripKit] convert, fix and update ModeCombinationStrategyTest.java to kotlin
- [TripKit] fix failing tests on RegionServiceImplTest.kt and update to use MockK
- [TripKit] convert RoutingResponseTest.java to kotlin and re-enable commented out test
- [TripKit] convert TemporaryUrlApiTest.java to kotlin and use MockK
- [TripKit] convert UuidProviderTest.java to kotlin and use MockK
- [TripKitUI] variable adjustment
- [TripKit] add @JvmSuppressWildcards to accept Any as a type on Map
Copy link

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

@github-actions github-actions bot added the Stale label Dec 2, 2024
@MichaelReyes MichaelReyes removed the Stale label Dec 3, 2024
@MichaelReyes MichaelReyes merged commit 1cc79bf into develop Dec 3, 2024
1 check passed
@MichaelReyes MichaelReyes deleted the task/22682-tripkitui-refactor branch December 3, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants