Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22321] Updated android ci workflow #465

Closed
wants to merge 0 commits into from

Conversation

sg-jsonjuliane
Copy link
Contributor

PR Context

  • Type: Feature
  • Issue Link: Redmine Issue
  • Risk Factor: Low - The workflow only affects GitHub Actions and does not impact the core functionality of the app.

Changes

This PR introduces a GitHub Actions workflow that automatically runs unit tests on push and pull_request events. The key changes include:

  • Creation of a YAML file in .github/workflows/.
  • Configured triggers for push and pull_request events.
  • Set up the environment and dependencies required to run unit tests.
  • Added steps to build the project and execute the unit tests.
  • Configured notifications to be sent when test failures occur.
  • Tested the workflow using a dummy pull request to ensure functionality.

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: Are all changes, new functionalities, and classes documented with KDocs?
  • Architectural Patterns: Is there consistent and proper use of architectural patterns (e.g., MVVM, MVP)?

Testing and Reliability

  • Unit Testing: Are there unit tests for all new functionalities and classes?
  • Emulator and Real Device Testing: Has the application been tested on both emulators and real devices to ensure compatibility?

Error Handling and Logging

  • Error Handling: Are errors and exceptions caught and handled gracefully, ensuring the app remains stable?
  • Logging: Is there proper logging in place for critical errors and information, aiding in debugging and monitoring?

Testing Procedure

If applicable, provide steps or commands for testing your changes. This can help reviewers and testers.

  • Push or create a pull request in the repository.
  • Confirm that the GitHub Actions workflow is triggered.
  • Check if the unit tests run successfully and notifications are sent for failures.

@sg-jsonjuliane sg-jsonjuliane self-assigned this Oct 10, 2024
@sg-jsonjuliane sg-jsonjuliane force-pushed the feature/22321-android-ci branch from 59008a7 to ea5b748 Compare October 10, 2024 15:57
@skedgo skedgo deleted a comment from github-actions bot Oct 10, 2024
@skedgo skedgo deleted a comment from github-actions bot Oct 10, 2024
Copy link

❌ Workflow execution failed!

@sg-jsonjuliane, there was an issue with the workflow execution. Please check the logs and resolve the issue.

1 similar comment
Copy link

❌ Workflow execution failed!

@sg-jsonjuliane, there was an issue with the workflow execution. Please check the logs and resolve the issue.

@sg-jsonjuliane sg-jsonjuliane force-pushed the feature/22321-android-ci branch from 63cacb4 to a53bd46 Compare October 10, 2024 16:18
Copy link

❌ Workflow execution failed!

@sg-jsonjuliane, there was an issue with the workflow execution. Please check the logs and resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant