Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20604] Ticket update on logout and signing in with a different user fix #417

Merged
merged 1 commit into from
Mar 6, 2024
Merged

[20604] Ticket update on logout and signing in with a different user fix #417

merged 1 commit into from
Mar 6, 2024

Conversation

MichaelReyes
Copy link
Collaborator

  • [TripGoV5] Handle ActiveBookingItem visibility on user logout.
  • [TripKit]Adjust AddCustomHeaders to not include empty token
  • [TripGov5] check initiation in onresume for HomeBottomSheetItemManagers
  • [TripKitUI] Add custom binding in CustomBinding.kt for handling view visibility by height setting
  • [TripGov5] update HomeBottomSheetItemManager and add flag for including HomeItemSpacer when added to home cards
  • [TripGov5] update parameters for TransitTicketItemManager and only include token provider instead of having both token provider and user account repository
  • [TripGov5] Update TripGoAccountSettingsManager to add common fun clear auth and update child classes accordingly
  • [TripGov5] update transit_ticket_item.xml for handling visibility (by height) when ticket polling is active
  • [TripGov5] handle on resume to check if auth token is available and if polling is active to toggle card visibility and re-run polling if different user

@MichaelReyes
[20604] *[TripGoV5] Handle ActiveBookingItem visibility on user logout.
ff252ef 
*[TripKit]Adjust AddCustomHeaders to not include empty token
*check initiation in onresume for HomeBottomSheetItemManagers
*Add custom binding in CustomBinding.kt for handling view visibility by height setting
*update HomeBottomSheetItemManager and add flag for including HomeItemSpacer when added to home cards
*[TripGov5] update parameters for TransitTicketItemManager and only include token provider instead of having both token provider and user account repository
*[TripGov5] Update TripGoAccountSettingsManager to add common fun clear auth and update child classes accordingly
*[TripGov5] update transit_ticket_item.xml for handling visibility (by height) when ticket polling is active
*[TripGov5] handle on resume to check if auth token is available and if polling is active to toggle card visibility and re-run polling if different user
@MichaelReyes MichaelReyes merged commit 19648ed into develop Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sg-jsonjuliane sg-jsonjuliane sg-jsonjuliane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelReyes @sg-jsonjuliane