Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20495] Handle outbound and return trip booking failures from server DRT. Revisit and revamp certain logics within the DRT feature. #412

Merged
merged 2 commits into from
Feb 29, 2024
Merged

[20495] Handle outbound and return trip booking failures from server DRT. Revisit and revamp certain logics within the DRT feature. #412

merged 2 commits into from
Feb 29, 2024

Conversation

MichaelReyes
Copy link
Collaborator

@MichaelReyes MichaelReyes commented Feb 9, 2024 •
edited
Loading

  • [TripKitUI][TripKit] Handle warning on payment response if return trip was not booked.
  • [TripKitUI][TripKit] Handle error from server if outbound trip was not booked
  • [TripGov5][TripKitUI] Update logic related to DRT footer action.
  • [TripGov5][TripKitUI][TripKit] staging build type with staging configuration changes for waupaca(Catch a ride)

@MichaelReyes MichaelReyes marked this pull request as ready for review February 20, 2024 15:58
@MichaelReyes
[20495] *Handle warning on payment response if return trip was not bo…
e702e27 
…oked.

*Handle error from server if outbound trip was not booked
*Update logic related to DRT footer action.
@MichaelReyes
[20495] *DRT handling updates. *staging build type to easily create s…
c236468 
…taging builds per white label
@MichaelReyes MichaelReyes force-pushed the feature/20495-server-booking-errors-handling branch from f9f6a70 to c236468 Compare February 21, 2024 02:06
sg-jsonjuliane
sg-jsonjuliane approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@sg-jsonjuliane sg-jsonjuliane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Well updated and written, nothing to raise

@MichaelReyes MichaelReyes merged commit 2b1ecdd into develop Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sg-jsonjuliane sg-jsonjuliane sg-jsonjuliane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelReyes @sg-jsonjuliane