Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19730] Region selected focus #407

Merged
merged 2 commits into from
Jan 17, 2024
Merged

[19730] Region selected focus #407

merged 2 commits into from
Jan 17, 2024

Conversation

MichaelReyes
Copy link
Collaborator

Changes

  • [TripKitUI] Focus map to selected client's region
  • [TripGoSdk] Update TripGoSharedPreference to make it injectable and not initialized by application context to avoid memory leakage.
  • [TripKit] Create TripKitSharedPreference to centralize handling SharePreference logic for TripKit
  • [TripGoSdk & TripKit] Setup MockK
  • [TripGoSdk] Written unit test for the new TripGoSharedPreference class
  • [TripKit] Written unit test for the new TripKitSharedPreference class

Unit Test

Screenshot 2024-01-15 at 11 06 26 PM

@MichaelReyes
[19730] *Update TripGoSharedPreference to make it injectable and not …
e709082 
…initialized by application context to avoid memory leakage.

*Create TripKitSharedPreference to centralize handling SharePreference logic for TripKit
*Focus map to selected client's region
@MichaelReyes
[19730] *Add TripGoSharedPreferenceTest.
a6c64b2 
*Add TripKitSharedPreferenceTest
@MichaelReyes MichaelReyes merged commit d5d8e07 into develop Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sg-jsonjuliane sg-jsonjuliane sg-jsonjuliane approved these changes

@lenganngoh lenganngoh Awaiting requested review from lenganngoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelReyes @sg-jsonjuliane