Изменение размера кнопки в FxInput при передаче пропа size #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
lossir
reviewed
May 6, 2021
|
|
||
| export default { title: 'FxInput' }; | ||
|
|
||
| export const TypeText = () => <TestFxInput />; | ||
| TypeText.story = { name: 'type text' }; | ||
|
|
||
| export const DifferentSizesFxInput = () => ( | ||
| <Gapped vertical> | ||
| <TestFxInput /> |
There was a problem hiding this comment.
Давай здесь укажем размер, на случай если мы решим изменить дефолтный размер.
Suggested change
| <TestFxInput /> | |
| <TestFxInput size="small" /> |
StathamJason
force-pushed
the
fx-input-sizes
branch
from
ba9441c to
c85a335
Compare
lossir
approved these changes
May 7, 2021
zhzz
approved these changes
May 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
size="large" и "medium" ломает FxInput — меняется только инпут
#1733
Фикс для последнего пункта из раздела "Проблемы, которые нужно решить параллельно"