Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: focus border color and menu items bg color changed to #1D85D0 #2330

Merged
merged 6 commits into from
Apr 7, 2021

Conversation

draugi
Copy link
Contributor

@draugi draugi commented Mar 25, 2021

fix #2329
BREAKING CHANGE: Color of focus border and background of active menu items changed from #5199db to #1D85D0

Для @dzekh
Есть переменные в darkTheme.ts, которые используют цвет #5199db. Посмотри, пожалуйста, что потом с ними делать:

blueLight
bgActive
borderColorFocus
tabColorFocus
calendarCellHoverBgColor
calendarCellSelectedBgColor
dateSelectMenuItemBgActive
dateSelectMenuItemBgSelected
pickerTodayWrapperHoverBgColor
toggleFocusShadowColor

@vercel
Copy link

vercel bot commented Mar 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

storybook-8px – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-8px/AorC4RTRHwVcdqXwTH8SSeXnGfaQ
✅ Preview: https://storybook-8px-git-change-color-focus-and-menu-items-reactui.vercel.app

storybook-flat – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-flat/88kcHDVnCv4K9oFaTCqZVsmajCZo
✅ Preview: https://storybook-flat-git-change-color-focus-and-menu-items-reactui.vercel.app

storybook-default – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-default/D6oF4m9QAGTXQBYo2c7kZBoMekpH
✅ Preview: https://storybook-default-git-change-color-focus-and-menu-items-reactui.vercel.app

@draugi draugi requested a review from lossir March 25, 2021 11:53
@vercel vercel bot temporarily deployed to Preview – storybook-default March 25, 2021 11:59 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 25, 2021 16:03 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 25, 2021 16:03 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 25, 2021 16:03 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-8px March 29, 2021 12:59 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-flat March 29, 2021 12:59 Inactive
@vercel vercel bot temporarily deployed to Preview – storybook-default March 29, 2021 12:59 Inactive
@draugi draugi requested a review from lossir March 30, 2021 06:17
Copy link
Member

@lossir lossir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzekh Пара мест, привязанных к переменной blueLight.

Цвет линии активной вкладки в компоненте Tabs.
Рядом вариант с фокусом на активной вкладке.
image image
Синий token image

@dzekh
Copy link

dzekh commented Apr 1, 2021

@dzekh Пара мест, привязанных к переменной blueLight.

Если это все изменилось — ок, всё правильно.

@draugi draugi marked this pull request as ready for review April 2, 2021 07:42
@draugi draugi requested review from dzekh, zhzz and StathamJason April 2, 2021 07:42
Copy link
Member

@zhzz zhzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lossir lossir merged commit 35c325d into next Apr 7, 2021
@lossir lossir deleted the change-color-focus-and-menu-items branch April 7, 2021 12:05
@lossir lossir mentioned this pull request Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants