Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update all deps #2217

Merged
merged 39 commits into from
Apr 11, 2021
Merged

build: update all deps #2217

merged 39 commits into from
Apr 11, 2021

Conversation

lossir
Copy link
Member

@lossir lossir commented Nov 19, 2020

Обновленно

  • root deps
    • @commitlint/cli
    • @commitlint/config-conventional
    • commitizen
    • cz-conventional-changelog
    • env-cmd
    • husky
    • lerna
  • typescript + eslint(and related deps)
    • @typescript-eslint/eslint-plugin
    • @typescript-eslint/parser
    • eslint
      • изменились умолчательное значения некоторых правил
    • eslint-config-prettier
    • eslint-plugin-import
    • eslint-plugin-jsx-a11y
    • eslint-plugin-react
    • eslint-plugin-react-hooks
    • typescript
      • зафиксирвал версию 4.1.3, из-за ошибки с __spreadArray
  • deps for operability
    • eventemitter3
    • tabbable
      • Немного изменился синтаксис
    • @skbkontur/react-icons
    • @skbkontur/react-props2attrs
    • @types/invariant
    • @types/tabbable
      • Типы теперь вшиты в tabbable
  • babel and deps that are used to build. for storybook and styleguide
    • @babel/core
    • @babel/plugin-proposal-decorators
    • @babel/plugin-transform-runtime
    • @babel/preset-env
    • @babel/preset-react
    • @babel/register
    • babel-loader
    • chalk
    • copyfiles
    • core-js
    • cross-env
    • css-loade
    • dts-css-modules-loader
    • file-loader
    • fork-ts-checker-webpack-plugin
    • fs-extra
    • gh-pages
    • react-docgen-typescript
    • semver
    • style-loader
    • upath
    • url-loader
    • wait-on
    • stylelint-config-css-modules
      • Не используется
    • stylelint
    • stylelint-config-standard
    • mockdate
      • Не используется
    • babel-polyfill
    • csstype
    • selenium-webdriver
  • emotion. update to 11 (https://emotion.sh/docs/emotion-11)
    • @emotion/css (вместо create-emotion)
    • smoke test SSR
      • @emotion/server (вместо create-emotion-server)
      • @emotion/react (вместо @emotion/core)
  • jest + enzyme
  • react
    • react
      До версии 16.14.0
  • react-ui-validation
    • @babel/plugin-transform-runtime
    • @babel/preset-env
    • @hot-loader/react-dom
    • @types/jest
    • @types/react-syntax-highlighter
    • @types/styled-components
    • babel-jest
    • core-js
    • cross-env
    • css-loader
    • file-loader
    • gh-pages
    • html-webpack-plugin
    • jest
    • less
    • less-loader
      • Версия 8.0 не поддерживает webpack@4, поэтому поставил 7.3.0
    • @skbkontur/react-props2attrs и @skbkontur/react-sorge
      • Установил вместо файла react-selenium-testing.js
    • @skbkontur/react-icons
    • react-helmet
    • react-syntax-highlighter
    • rollup
    • rollup-plugin-typescript2
    • string-replace-loader
    • style-loader
    • styled-components
    • ts-jest
    • ts-loader
    • Storbook:
      • Немного обвил конфиги.
      • Удалил less для историй и добавил стили как в библиотеки контролов

Не обновлено:

React@17

Есть ломающие изменения, которые не позволяют "просто" использовать одновременно 16 и 17 версии.
Надо придумать, как добавить поддержку обоих версий.

Storybook@6

Не удалось устранить все проблемы в ie11.

Webpack@5

Возникли проблемы при запуске creevey. Хотя "официально" поддержка только готовится, удалось завести на Storybook@5.

@lossir lossir force-pushed the update-all-deps-IF-54 branch from d74d1a8 to a466980 Compare November 19, 2020 15:55
@lossir lossir force-pushed the update-all-deps-IF-54 branch from 01220bf to 41aa55b Compare January 26, 2021 13:28
@lossir lossir force-pushed the update-all-deps-IF-54 branch from 6ed771a to c2bf8c7 Compare February 26, 2021 09:11
@lossir lossir changed the base branch from master to next February 26, 2021 09:21
@lossir lossir force-pushed the update-all-deps-IF-54 branch 4 times, most recently from 21a7bf4 to 9fd3001 Compare February 28, 2021 22:23
@lossir lossir force-pushed the update-all-deps-IF-54 branch 2 times, most recently from 66bf6da to 39f3f34 Compare March 2, 2021 22:23
@lossir lossir force-pushed the update-all-deps-IF-54 branch from f4b9d57 to eb565eb Compare March 3, 2021 05:53
@lossir lossir marked this pull request as ready for review March 3, 2021 07:22
@lossir lossir requested review from StathamJason and zhzz March 3, 2021 07:22
Copy link
Member

@zhzz zhzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом выглядит хорошо. Еще не все отсмотрел. Есть парочка предложений.

packages/eslint-config/.eslintrc Show resolved Hide resolved
packages/react-ui/package.json Outdated Show resolved Hide resolved
Copy link
Member

@zhzz zhzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Похоже, что все изменения в тестах, которые не касаются типов - лишние. Проверил, без них работает.

И да, можно еще раз пройтись. Уже снова накопилось достаточно обновлений. Особенно интересует emotion@11.

Пакеты, которые можно удалить: csstype, selenium-webdriver.

packages/react-ui/package.json Outdated Show resolved Hide resolved
…ntur/retail-ui into update-all-deps-IF-54

� Conflicts:
�	packages/react-ui/components/Fias/Fias.md
�	packages/react-ui/components/Fias/FiasSearch/FiasSearch.md
�	packages/react-ui/components/Fias/FiasSearch/FiasSearch.tsx
�	packages/react-ui/components/Fias/Form/__tests__/FiasComboBox-test.tsx
�	packages/react-ui/components/Logotype/Logotype.md
�	packages/react-ui/components/TopBar/TopBar.md
@vercel
Copy link

vercel bot commented Mar 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

storybook-8px – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-8px/2w67xtzXWBrw2UGq8RXb8ooA1GPF
✅ Preview: https://storybook-8px-git-update-all-deps-if-54-reactui.vercel.app

storybook-flat – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-flat/2tUizFCeEpus1iDT3RJbgDYznGtD
✅ Preview: https://storybook-flat-git-update-all-deps-if-54-reactui.vercel.app

storybook-default – ./packages/react-ui

🔍 Inspect: https://vercel.com/reactui/storybook-default/53e8b1kLS97bJY5cHKpaLGLJM7wF
✅ Preview: https://storybook-default-git-update-all-deps-if-54-reactui.vercel.app

@lossir lossir force-pushed the update-all-deps-IF-54 branch 2 times, most recently from 9f1578b to c445233 Compare April 8, 2021 09:53
@lossir lossir removed the in progress label Apr 8, 2021
@lossir lossir requested a review from zhzz April 9, 2021 09:11
@zhzz
Copy link
Member

zhzz commented Apr 11, 2021

Оказалось, что хуки с проверкой git-lfs генерируются им самим автоматически. Поэтому снова добавил их в репу. На винде все это работает, проверил. Эти хуки правда будут мешать при переключении на старые ветки. Если что, можно будет их там заигнорить.

Добавил еще ссылку на предыдущий пример SSR для 2.x.

@zhzz zhzz merged commit 7cff9d3 into next Apr 11, 2021
@zhzz zhzz deleted the update-all-deps-IF-54 branch April 11, 2021 09:09
@zhzz zhzz mentioned this pull request Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants