Merge pull request #1623 from skaut/frontend-strict-tsconfig-with-ski…

…pLibCheck [frontend] Stricter tsconfig (with skipLibCheck)
skaut · Sep 13, 2024 · a185ef2 · a185ef2
2 parents febb1fe + a423e19
commit a185ef2
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 12 deletions.
diff --git a/packages/frontend/__tests__/components/IssuesList.test.tsx b/packages/frontend/__tests__/components/IssuesList.test.tsx
@@ -20,8 +20,9 @@ describe("IssuesList component", () => {
       <MemoryRouter>
         <IssuesList
           issues={project.issues.map((issue) => ({
-            ...issue,
-            link: undefined,
+            description: issue.description,
+            number: issue.number,
+            title: issue.title,
           }))}
           project={project}
         />

diff --git a/packages/frontend/src/components/Issue.tsx b/packages/frontend/src/components/Issue.tsx
@@ -19,7 +19,7 @@ export const Issue = ({
     subtitle={issue.project.name}
     subtitleDescription={issue.project["short-description"]}
     subtitleLink={getProjectLink(issue.project)}
-    tags={!hideTags ? issue.project.tags : []}
+    tags={!hideTags ? (issue.project.tags ?? []) : []}
     title={issue.title}
   />
 );
diff --git a/packages/frontend/src/components/Project.tsx b/packages/frontend/src/components/Project.tsx
@@ -13,7 +13,7 @@ export const Project = ({
   <ArticleBox
     description={project.info.description}
     link={getProjectLink(project)}
-    tags={project.info.tags}
+    tags={project.info.tags ?? []}
     title={project.info.name}
   />
 );
diff --git a/packages/frontend/src/pages/IssueDetail.tsx b/packages/frontend/src/pages/IssueDetail.tsx
@@ -47,8 +47,8 @@ export const IssueDetail = ({
   );
   const projectIssues = getIssuesWithProjectInfo(data, {
     omitIssueNumber: issue?.number,
-    owner: projectOwner,
-    repo: projectRepo,
+    ...(projectOwner !== undefined && { owner: projectOwner }),
+    ...(projectRepo !== undefined && { repo: projectRepo }),
   });
 
   if (!issue) {

diff --git a/packages/frontend/src/utils/getAllIssues.ts b/packages/frontend/src/utils/getAllIssues.ts
@@ -8,7 +8,7 @@ export interface ProjectIssueWithProjectInfo extends ProjectIssue {
 }
 
 interface Query extends Partial<Project> {
-  omitIssueNumber?: number;
+  omitIssueNumber: number | undefined;
 }
 
 export const getIssuesWithProjectInfo = (

diff --git a/packages/frontend/tsconfig.json b/packages/frontend/tsconfig.json
@@ -1,17 +1,25 @@
 {
   "compilerOptions": {
-    "module": "es2020",
-    "moduleResolution": "node",
     "allowSyntheticDefaultImports": true,
     "esModuleInterop": true,
-    "target": "es5",
-    "jsx": "react-jsx",
     "forceConsistentCasingInFileNames": true,
+    "jsx": "react-jsx",
+    "module": "es2020",
+    "moduleResolution": "node",
+    "sourceMap": true,
+    "target": "es5",
+
+    "skipLibCheck": true,
+
+    "allowUnreachableCode": false,
+    "allowUnusedLabels": false,
+    "exactOptionalPropertyTypes": true,
     "noFallthroughCasesInSwitch": true,
+    "noImplicitOverride": true,
     "noImplicitReturns": true,
+    "noPropertyAccessFromIndexSignature": true,
     "noUnusedLocals": true,
     "noUnusedParameters": true,
-    "sourceMap": true,
     "strict": true
   }
 }