docs(meetings): add additional notes stuff #2

Hotell · 2017-05-18T23:36:55Z

Here it is folks!

thx for answering etc in Advance

treshugart · 2017-05-22T16:46:20Z

meetings/2017/05-18.md

+
+## @hotell questions
+
+- since `webcomponents.js` **1.0** is out ( YES ALSO on NPM finally !!!) we can drop our custom skatejs/webcomponents ? ( our custom ones doesnt work with Angular )


I think this is a great idea. Have they made lazy-loading the necessary polyfills simple? The main issues I've had with it is the sheer amount of friction to just get a cross-browser simple example working in a reasonable amount of time.

I'll try it out and will let you know ( I need this for demo of my upcoming talk )

works like a charm, although slightly complicated config

this is dev mode === not minified/gzipped
-> also webpack is putting it's HMR etc in that polyfill.js file ( probably that's why it's so big )

overall zero kB on browsers with full support, what is unfortunate is that it loads HTML Import shim which is very huge - maybe worth to fork and tweak that loader for own particular needs -> for skate projects ? WDYT

treshugart · 2017-05-22T16:47:07Z

meetings/2017/05-18.md

+
+- since `webcomponents.js` **1.0** is out ( YES ALSO on NPM finally !!!) we can drop our custom skatejs/webcomponents ? ( our custom ones doesnt work with Angular )
+
+- what will/is the new size skate 5.x + preact 8.x as renderer ( marketing )


Skate is something like 3.6k or something. I think general convention here is to round down, just to make things look better, but I'm not fussed.

I don't think we need to give a "size with Preact" number as then we have to maintain that along with Jason reducing his bundle size.

yup agreed ;)

treshugart · 2017-05-22T16:49:08Z

meetings/2017/05-18.md

+
+- what will/is the new size skate 5.x + preact 8.x as renderer ( marketing )
+
+- what type of source are we gonna ship ?


Yep, just UMD (in umd/) + ES2015 (in es/). The es/ will be kept up to date with the latest ES spec, within reason. We still need to figure out whether we bump major versions as specs become finalised.

as I tweeted recently, I think this approach is not completely ok. We definitely need the module in package json for es6 modules + es5 transpiled and es2015 for just esNext. But we can iterate in feature release or so, no pressure

Yeah, okay. I think that's simple enough to provide because all we need to do is:

Re-enable the esModule build with NWB

Change the es/ output directory for the Babel step to es-next/ or es-latest/.

Bikeshed the name of the new directory because it becomes API.

treshugart · 2017-05-22T16:49:50Z

meetings/2017/05-18.md

+  - UMD
+  - ES 2015 + modules ( three shakable or can be used as is without native-shim)
+
+# PR


😄

This is awesome! I like that we add stuff like this here.

haha PR is important in OSS, stupid projects like cat feeder etc have 5k stars ehm ehm, I really thing that this project is revolutionary and really the only sane way how to write WC for anyone ( who prefers reactive/functional way) ( especially with turned off ShadowDOM for enterprise/legacy apps - which need to support IE9 and so on )

treshugart · 2017-05-22T16:50:24Z

meetings/2017/05-18.md

@@ -19,11 +22,330 @@ Attendees
 - Would be good to have Flow in sooner rather than later.
  - If TypeScript definitions change if we merged it later, then it could possibly break (low risk).

+## 5.x recap


Awesome. Thank you so much for compiling this information!

treshugart · 2017-05-22T16:50:33Z

meetings/2017/05-18.md


 Attendees

 - @matthewp
 - @treshugart
+- @hotell ( offline after meeting notes )


nit: inconsistent parenthesis spacing (mostly trolling :p)

:D well I written this down at 2 am after watching alien:covenant so :D 🗡

treshugart · 2017-05-22T16:51:59Z

meetings/2017/05-18.md

+
+### Component reference via Constructor
+
+> isn't possible in 5.x ( Preact doesn't recognises custom-element via CTOR )


@developit (I'm being lazy) are there any plans to implement this? I'd be happy to contribute it if there's nothing in the pipeline yet.

created issue for that preactjs/preact#704

treshugart · 2017-05-22T16:53:49Z

meetings/2017/05-18.md

+define(MyComponent)
+```
+
+**5.x**


I reckon we should simplify these examples as much as possible to highlight the exact change. Like even just a <Hello /> example.

yeah I was thinking too, to just provide diff but having whole example is easier to grook. What we can do is to have the diff at first and then both version whole examples WDYT ?

Maybe simple for showing the diff, and at the end show an example with all the changes?

kk I'm on it

treshugart · 2017-05-22T16:55:14Z

meetings/2017/05-18.md

+
+### return Array as root node
+
+> isn't possible in 5.x ( Preact doesn't support rendering arrays as React Fiber for instance )


If I could put money on it, it's in the works. We could patch the Preact renderer (src/with-component.js) in Skate to allow this, if we really wanted.

yeah I saw some retweet by @developit that someone has a working prototype but perf is terrible at the moment ( according to that tweet )

Hard to say if we should monkey patch it hmm, I guess we should for those components for layout, also easier migration from v4

treshugart · 2017-05-22T16:55:35Z

meetings/2017/05-18.md

+### return Array as root node
+
+> isn't possible in 5.x ( Preact doesn't support rendering arrays as React Fiber for instance )
+> Critical refactoring especially for apps that are using custom-elements for layout via Flexbox


This is true. Maybe we should put it in Preact?

I think it is in Preact docs already no ?

... Nope, there isn't any mention in the docs https://preactjs.com/guide/lifecycle-methods

treshugart · 2017-05-22T16:57:05Z

meetings/2017/05-18.md

+### return Array as root node
+
+> isn't possible in 5.x ( Preact doesn't support rendering arrays as React Fiber for instance )
+> Critical refactoring especially for apps that are using custom-elements for layout via Flexbox


Maybe it'd be best to have a compat package that can make things smoother. As mentioned in previous meetings, you can have several versions of Skate side-by-side, so I'm not sure this is a huge issue. Could also write code shifts for it.

you cannot write code shifts for css AFAIK

Oh right because returning arrays is only half the battle. Don't think so.

but I guess we have to be consistent and don't provide surprises for user who would use they custom renderer which may not support returning arrays as root ? dont know hmm

treshugart · 2017-05-22T17:01:45Z

meetings/2017/05-18.md

+define(MyComponent)
+```
+
+**5.x**


I can't spot the breaking change here. Can we simplify this to the most simple form (should probably do this for all examples)?

props( this, {myArray: ['hello']} ) vs this.props = { myArray: ['hello'] }

treshugart · 2017-05-22T17:03:06Z

meetings/2017/05-18.md

 ## Flow

 - Flow can be merged sooner rather than later if we can get `get-typed` published.

+- need explanation of TS generated files by Flow secret tool before merging as LGTM types, see -> https://github.com/skatejs/skatejs/pull/1163#discussion_r116605816


What I mean here is that we can merge and still maintain the TS types until that is done, but I agree, I think it might be better to hold off on that and make the integration seamless.

cheers on that !

Hotell · 2017-05-22T21:01:45Z

allright added diffs, custom base creation, links ...

pls re-review , if LGTM we can merge and iterate further if needed

Hotell · 2017-05-23T23:00:24Z

huh so I've migrated my starter-kit and that issue with Flex layouts and not be able to render array as root is really "painful" :( Hotell/skate-starter#1

treshugart · 2017-05-24T00:16:32Z

Can't you instead of applying flex stuff to :host, just do it to the wrapping div?

Hotell · 2017-06-01T07:15:51Z

can we merge this and iterate on more merging diffs please ?

I will start upgrading docs as well

Hotell requested review from treshugart and matthewp May 18, 2017 23:36

Hotell force-pushed the may-meeting-notes-additions branch 2 times, most recently from 3a977be to ce12bee Compare May 18, 2017 23:41

Hotell changed the title ~~docs(meeings): add additional notes stuff~~ docs(meetings): add additional notes stuff May 18, 2017

docs(meeings): add additional notes stuff

ce12bee

treshugart reviewed May 22, 2017

View reviewed changes

Hotell added 3 commits May 22, 2017 20:41

docs: add git diff for all examples before whole code example

d7247c2

docs: add list for changes

d564ebc

docs: add example how to define custom base

3b26210

Hotell force-pushed the may-meeting-notes-additions branch from 9e159e9 to 3b26210 Compare May 22, 2017 20:57

docs: fix path to skatejs

287b33c

Hotell mentioned this pull request May 23, 2017

build: add back es module + transpiled output skatejs/skatejs#1181

Merged

treshugart merged commit 24cd8ea into master Jun 1, 2017

treshugart deleted the may-meeting-notes-additions branch June 1, 2017 16:42


		## @hotell questions

		- since `webcomponents.js` 1.0 is out ( YES ALSO on NPM finally !!!) we can drop our custom skatejs/webcomponents ? ( our custom ones doesnt work with Angular )


		- since `webcomponents.js` 1.0 is out ( YES ALSO on NPM finally !!!) we can drop our custom skatejs/webcomponents ? ( our custom ones doesnt work with Angular )

		- what will/is the new size skate 5.x + preact 8.x as renderer ( marketing )


		- what will/is the new size skate 5.x + preact 8.x as renderer ( marketing )

		- what type of source are we gonna ship ?


		### Component reference via Constructor

		> isn't possible in 5.x ( Preact doesn't recognises custom-element via CTOR )


		### return Array as root node

		> isn't possible in 5.x ( Preact doesn't support rendering arrays as React Fiber for instance )

docs(meetings): add additional notes stuff #2

docs(meetings): add additional notes stuff #2

Conversation

Hotell commented May 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hotell May 24, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hotell May 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hotell commented May 22, 2017

Hotell commented May 23, 2017

treshugart commented May 24, 2017

Hotell commented Jun 1, 2017

Hotell May 24, 2017 •

edited

Loading

Hotell May 22, 2017 •

edited

Loading