Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/2053 remove hunter #2061

Merged
merged 15 commits into from
Jan 2, 2025
Merged

Enhancement/2053 remove hunter #2061

merged 15 commits into from
Jan 2, 2025

Conversation

olehnikolaiev
Copy link
Contributor

@olehnikolaiev olehnikolaiev commented Dec 26, 2024 •
edited
Loading

fixes #2053

removed hunter from dependencies, move required packages' to build.sh

tested on the devnet - versions are compatible

no performance impact

@github-actions GitHub Actions
Copy link

SUGGESTIONS BEFORE MERGE:

  1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
  2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
  3. Edit VERSION file appropriately to your changes!
    See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions

@olehnikolaiev olehnikolaiev linked an issue Dec 26, 2024 that may be closed by this pull request
don't use hunter to build dependencies #2053
Closed
@olehnikolaiev olehnikolaiev marked this pull request as ready for review January 2, 2025 11:21
@olehnikolaiev olehnikolaiev merged commit 20f93f9 into v3.21.0 Jan 2, 2025
4 of 5 checks passed
@olehnikolaiev olehnikolaiev deleted the enhancement/2053-remove-hunter branch January 2, 2025 19:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DmytroNazarenko DmytroNazarenko DmytroNazarenko approved these changes

@kladkogex kladkogex kladkogex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

don't use hunter to build dependencies
3 participants
@olehnikolaiev @kladkogex @DmytroNazarenko