New deployment management

[DmytroNazarenko]

Description

This feature enhances the flexibility of contract deployment management. Previously, during contract creation, skaled invoked the ConfigController smart contract by passing only msg.sender as an argument to check whether address is able to deploy contracts:

ConfigController.isAddressWhitelisted(address sender) -> bool

With the new version, if the feature is enabled, skaled will pass two parameters - tx.origin and msg.sender into the call to check whether address is able to deploy:

ConfigController.isDeploymentAllowedCallData(address origin, address sender) -> bool

Patch

The feature is enabled by the FlexibleDeploymentPatchTimestamp.

Tests

A unit test has been added: JsonRpcSuite/deployment_control_v2.

Integration test

Tested on devnet

1. Update ConfigController contract to the v2 version on chain A
2. Set FlexibleDeploymentPatchTimestamp to the current timestamp for chain A
3. Update skaled version
4. Whitelist deployer address X
5. Deploy ContractFactory from address X
6. Try to deploy contract using ContractFactory from address Y -> fail
7. Whitelist address Y as allowed origin for ContractFactory
8. Try to deploy contract using ContractFactory from address Y -> success
9. Try to deploy contract using ContractFactory from address X -> success
10. Try to deploy contract using ContractFactory from address Z -> fail

Contracts for testing:

// SPDX-License-Identifier: GPL-3.0

pragma solidity ^0.8.24;

contract Factory {
    event ContractAddress(address contractAddress);
    // Returns the address of the newly deployed contract
    function deploy(address _owner, uint256 _foo, bytes32 _salt)
        public
        returns (address)
    {
        // This syntax is a newer way to invoke create2 without assembly, you just need to pass salt
        // https://docs.soliditylang.org/en/latest/control-structures.html#salted-contract-creations-create2
        address testContract = address(new TestContract{salt: _salt}(_owner, _foo));
        emit ContractAddress(testContract);
        return testContract;
    }
}


contract TestContract {
    address public owner;
    uint256 public foo;

    constructor(address _owner, uint256 _foo) {
        owner = _owner;
        foo = _foo;
    }

    function getBalance() public view returns (uint256) {
        return address(this).balance;
    }
}

Performance Impact

This feature introduces an additional parameter in the ConfigController call, with no significant impact on performance.

[github-actions]

SUGGESTIONS BEFORE MERGE:

1. Build custom container here: https://github.com/skalenetwork/skaled/actions?query=workflow%3A%22Custom+Docker+and+Binary%22
2. Test it here: https://github.com/skalenetwork/skale-ci-integration_tests/actions?query=workflow%3A%22Skaled+Nightly+Tests%22
3. Edit VERSION file appropriately to your changes!
   See https://skalelabs.atlassian.net/wiki/spaces/SKALE/pages/2444951553/Branching+instructions