Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxFeePerGas and maxPriorityFeePerGas are equal to 0 for type2 txns after eth_getTransaction call #1963

Closed
olehnikolaiev opened this issue Aug 16, 2024 · 1 comment · Fixed by #1985
Assignees
Labels
bug Something isn't working epic:eth-compatibility
Milestone

Comments

@olehnikolaiev
Copy link
Contributor

to reproduce:

send any type2 txn to skaled
call eth_getTransaction in geth with txn's hash

expected result: maxFeePerGas and maxPriorityFeePerGas should not be zero for type2 txn

actual result:

> eth.getTransaction("0x8de1475cb871bc1075b931bcd783327d5d6eb5e6d32aa677e381ef9d020de9b3")
{
  accessList: [],
  blockHash: "0xc3735e4759684083922d311e90c206bdfadee193dd99c3737755f5f9fc61a81f",
  blockNumber: 2,
  chainId: "0x69",
  from: "0xa68f946090c600eda6f139783077ee802afeb990",
  gas: 107709,
  gasPrice: 100000,
  hash: "0x8de1475cb871bc1075b931bcd783327d5d6eb5e6d32aa677e381ef9d020de9b3",
  input: "0x60806040526000805534801561001457600080fd5b5060e4806100236000396000f3fe6080604052348015600f57600080fd5b506004361060285760003560e01c8063371303c014602d575b600080fd5b60336035565b005b600160008082825401925050819055507f510e730eb6600b4c67d51768c6996795863364461fee983d92d5e461f209c7cf60005460405160749190608b565b60405180910390a1565b60858160a4565b82525050565b6000602082019050609e6000830184607e565b92915050565b600081905091905056fea264697066735822122050901526e09a78d5c5894459167bb695997ebaddd432753337368fc8b046e05964736f6c634300060a0033",
  maxFeePerGas: 0,
  maxPriorityFeePerGas: 0,
  nonce: 0,
  r: "0xf9a4c19fbaefc0f7688af89873c428902acd16b6fd38c605be97577beed8f275",
  s: "0x4bbe1dcb45f9e5a0febf00e3395cb9a9f08682590bb8d9498e79cb8f4e1aab7c",
  to: null,
  transactionIndex: 0,
  type: "0x2",
  v: "0xf5",
  value: 0,
  yParity: "0x0"
}
@oleksandrSydorenkoJ
Copy link

Verified on the Legacy network
skalenetwork/schain:3.19.2-beta.0
Skale chain: black-spherical-graffias

    transaction_type_data = {
        'maxPriorityFeePerGas': 100000,
        'maxFeePerGas': 300000,
        'gas': 100000,
        'chainId': web3.eth.chain_id,
        'type': 2
    }

> eth.getTransaction('0x96a4e79a770d1515009eee0d16444ed00d2770253b4ee1728f9eeb81eca72e47')
{
  accessList: [],
  blockHash: "0x001b61b3ff482ea660913ee1b1bd66c236ad231b847fcd332a9ff038772e3e60",
  blockNumber: 1357797,
  chainId: "0x28d08095",
  from: "0x71cbe3fede33905d4d1bf2bd51f9d4a62375e659",
  gas: 100000,
  gasPrice: 100000,
  hash: "0x96a4e79a770d1515009eee0d16444ed00d2770253b4ee1728f9eeb81eca72e47",
  input: "0x",
  maxFeePerGas: 300000,
  maxPriorityFeePerGas: 100000,
  nonce: 3722,
  r: "0x871f3994fd1a26cc15c95ad8c4f596c2f3ceec3a6812a2bc2c3b846f4b84f62b",
  s: "0x74dbde3975a40bb81fdeee0e7c10f4bdd1e5aab7080f89b9087d66d0ecc7c5e9",
  to: "0x71cbe3fede33905d4d1bf2bd51f9d4a62375e659",
  transactionIndex: 0,
  type: "0x2",
  v: "0x1",
  value: 0,
  yParity: "0x1"
}

@EvgeniyZZ EvgeniyZZ moved this from Ready For Release Candidate to Done in SKALE Engineering 🚀 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working epic:eth-compatibility
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants