Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent error message in py2 and py3 for error in Timestamp decode #258

Merged

Conversation

tockards
Copy link
Contributor

@tockards tockards commented Sep 14, 2022

This ensures that the error in Py2 and Py3 is consistent as the value is a str.

This is required for tests in other packages that rely on katcp-python and test katcp devices and failed responses.

Copy link
Contributor

@lanceWilliams lanceWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@tockards tockards merged commit f678b73 into master Sep 14, 2022
@tockards tockards deleted the user/tockards/P2M-143/consistent_error_in_py2_and_py3 branch September 14, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants