Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct handling of floats test sensor list #245

Merged

Conversation

tockards
Copy link
Contributor

This PR corrects the handling of floats in thesensor_tuple helper function used in test_sensor_list.

  • This adds a new float sensor with a zero to the right of the decimal point
  • Tests where the sensor is tested correctly inside test_sensor_list

Copy link
Contributor

@ajoubertza ajoubertza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the missing blank line.

katcp/test/test_server.py Outdated Show resolved Hide resolved
@tockards
Copy link
Contributor Author

@ajoubertza Thanks, this creeps in when I do my black format on a selected part of code and commit in a rush.

@tockards
Copy link
Contributor Author

Need to add the linting option to tox so that a developer can do it locally.

Copy link
Contributor

@mmphego mmphego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bmerry
Copy link
Contributor

bmerry commented Aug 28, 2020

I've started using pre-commit to define pre-commit hooks - it's a very nice Python wrapper around Git's hook system and it's saved me from making a lot of commits that would have failed flake8 or mypy.

@tockards
Copy link
Contributor Author

thanks @bmerry . Going to give it a try.

@tockards tockards merged commit c4d41fb into master Aug 31, 2020
@tockards tockards deleted the user/tockards/P2M-43/correct-handling-of-floats-test-sensor-list branch August 31, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants