-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct handling of floats test sensor list #245
Correct handling of floats test sensor list #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except for the missing blank line.
@ajoubertza Thanks, this creeps in when I do my black format on a selected part of code and commit in a rush. |
Need to add the linting option to tox so that a developer can do it locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I've started using pre-commit to define pre-commit hooks - it's a very nice Python wrapper around Git's hook system and it's saved me from making a lot of commits that would have failed flake8 or mypy. |
thanks @bmerry . Going to give it a try. |
This PR corrects the handling of floats in the
sensor_tuple
helper function used intest_sensor_list
.test_sensor_list