Custom icons for different types of notifications. #178
Conversation
* Add filled variant of the person_add icon * Add mention icon * Add custom icons for different notification types Co-authored-by: sk22 <[email protected]>
|
many thanks!! |
|
you're very welcome! i hope the implementation was okay, even tho I'm not really a java dev! I was also thinking about adding an option in the settings to enable / disable it, but my knowledge of the codebase and java is not (yet?) good enough to do that. |
|
oh me neither… i mean i did do a lot of java back in school, but never really lots of android. this project just kinda forced me back into it - like, it just started by adding back the federated timeline, which was simple enough 😅 |
|
also, thanks for discovering that fluent icons do actually include an @ icon - for some reason, upstream uses fluent icons for virtually anything except the @ symbol |
That's nice tho!! I am more of a Flutter dev, but I'll have to get used to Android native anyways because some things just can't be done in Flutter (Notifications for example).
Yep haha. Since I already added the icon to the drawables it should be an easy switch now. There's also already a PR (#476) upstream, that does exactly that, you could probably also just merge that. Ps.: You can also search through the fluent icons here just in case you didn't know already. |
This PR adds unique icons to the different notification types. In particular the following types got custom icons:
Below you can see examples of all of them except the polls.
Favorite icon in status bar
Mention icon in status bar
Reblog icon in status bar
Follow icon in status bar
Favorite icon in notification pll down
Mention icon in notification pll down
Reblog icon in notification pll down
Follow icon in notification pll down