Allow other options to ffmpeg

[albertsun]

Not sure about the syntax for the formatting of these options, but this was useful for Alastair and I so I figure it may be useful for others.

[sjwilliams]

@albertsun do you mind documenting the use in README.md and adding a test? We'll then push it out to npm as 0.1.1 for you and Alastair.

[albertsun]

Added. But no rush for pushing this out to npm, you may decide there's a more elegant solution for this.

It's not blocking us right now since we're installing from the forked version.

[sjwilliams]

I had some time to look at this today. I think there's a cleaner approach. I've worked up a feature branch that would allow you to, I think, achieve the same goal with this config:

options: {
    sizes: [{
        width: 640,
        filter: 'scale=640:trunc(ow/a/2)*2,crop=360:360:140:0',
        poster: true
    },{
        width: 320,
        poster: true
    }],
    additionalFlags: [
        {'-g': '3'}
    ]
}

Here, two sizes would be made. The 320 is standard. The 640 has your cropping magic.

For the filter, I just simplified the name. Everything is FFMpeg and custom, so just make the property filter.

For the additional flags, that functionality kinda already existed, but was clunky. You could have added the flag as part of a custom encode in the options.

options: {
  encodes: [
    mp4:
    [
        {'-flag', 'value'},
        {'-flag', 'value'},
        ....
        {'-g', '3'},
    ]
}

But you'd have had to look up the default settings in the source for that particular encode. And it's not DRY at all.

So, the additionalFlags property I'm proposing would allow you augment defaults (and any per-encode settings) by additionally adding this array of flags to the options passed into FFMpeg.

Does this interface make sense for what you and Alastair are doing? Either way, I like where this is going and will probably merge them into master after some testing. If you have time, feel free to use this branch and new interface. Holler if you do and I'll keep tweaking for you.

[albertsun]

Yep. That makes sense and is a lot cleaner than what I had hacked in.

Our project just wrapped tonight though, so I'll look to use this in a
future one.

On Mon, Mar 10, 2014 at 10:53 PM, Josh Williams [email protected]:

I had some time to look at this today. I think there's a cleaner approach.
I've worked up a feature branchhttps://github.com/sjwilliams/grunt-responsive-videos/tree/customoptionsthat would allow you to, I think, achieve the same goal with this config:

options: {
sizes: [{
width: 640,
filter: 'scale=640:trunc(ow/a/2)*2,crop=360:360:140:0',
poster: true
},{
width: 320,
poster: true
}],
additionalFlags: [
{'-g': '3'}
]}

Here, two sizes would be made. The 320 is standard. The 640 has your
cropping magic.

For the filter, I just simplified the name. Everything is FFMpeg and
custom, so just make the property filter.

For the additional flags, that functionality kinda already existed, but
was clunky. You could have added the flag as part of a custom encode in the
options.

options: {
encodes: [
mp4:
[
{'-flag', 'value'},
{'-flag', 'value'},
....
{'-g', '3'},
]}

But you'd have had to look up the default settings in the source for that
particular encode. And it's not DRY at all.

So, the additionalFlags property I'm proposing would allow you augment
defaults (and any per-encode settings) by additionally adding this array of
flags to the options passed into FFMpeg.

Does this interface make sense for what you and Alastair are doing? Either
way, I like where this is going and will probably merge them into master
after some testing. If you have time, feel free to use this branch and new
interface. Holler if you do and I'll keep tweaking for you.

Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-37258612
.

Albert Sun
[email protected]
215.253.8566