Fix #leaves used with a custom relation #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
#leaves
doesn't work properly with chained custom relations.The
#where_values_hash
method used in its implementation doesn't return everywhere
condition, e.g. it ignores the ones passed as raw SQL fragment strings, leading to an empty hash which then causes the method to just return an empty array.Here is a test case to illustrate the issue:
This PR fixes the issue by rewriting the query to check for leaf nodes based on https://stackoverflow.com/a/43512352.