Feat/#7 parse mobile links #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update api routes (replace get with post) - add tests request helpers - update integration tests
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to this hint from the description of #7
this issue was addressed in no time :)
This PR updates
parseSpotifyMetadata, to check if the link has the mobile format and then execute one extra request to get the desktop link (which is the only one that returns the required metadata).The
api/searchendpoint has also been updated to validate the API version and the HTTP GET verb has been replaced by POST to support spotify links with query params.Coverage is virtually 100%, so I'm confident that we can merge without side effects.
closes #7