Skip to content

Commit

Permalink
dev: also remove db-console/src/js/node_modules
Browse files Browse the repository at this point in the history
The dependencies for the CRDB JS protobuf client weren't previously getting
cleared during ./dev ui clean --all, which led to some quirks when
re-seeding the global yarn cache. Ensure all of the node_modules trees
get cleared with ./dev ui clean --all.

Release note: None
  • Loading branch information
sjbarag committed May 25, 2022
1 parent 7320115 commit 96137ef
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/cmd/dev/testdata/datadriven/ui
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,5 @@ rm -rf crdb-checkout/pkg/ui/workspaces/db-console/ccl/src/js/protos.d.ts
rm -rf crdb-checkout/pkg/ui/workspaces/cluster-ui/dist
rm -rf crdb-checkout/pkg/ui/node_modules
rm -rf crdb-checkout/pkg/ui/workspaces/db-console/node_modules
rm -rf crdb-checkout/pkg/ui/workspaces/db-console/src/js/node_modules
rm -rf crdb-checkout/pkg/ui/workspaces/cluster-ui/node_modules
1 change: 1 addition & 0 deletions pkg/cmd/dev/ui.go
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ func makeUICleanCmd(d *dev) *cobra.Command {
pathsToDelete,
filepath.Join(workspace, "pkg", "ui", "node_modules"),
filepath.Join(uiDirs.dbConsole, "node_modules"),
filepath.Join(uiDirs.dbConsole, "src", "js", "node_modules"),
filepath.Join(uiDirs.clusterUI, "node_modules"),
)
}
Expand Down

0 comments on commit 96137ef

Please sign in to comment.