Skip to content
This repository has been archived by the owner on Jun 14, 2019. It is now read-only.

VOLUME instruction causes trouble #22

Closed
joostmeijles opened this issue Feb 25, 2019 · 2 comments
Closed

VOLUME instruction causes trouble #22

joostmeijles opened this issue Feb 25, 2019 · 2 comments

Comments

@joostmeijles
Copy link
Contributor

joostmeijles commented Feb 25, 2019

I am using Windows 10 update 1809 and Docker Desktop for Windows 2.0.0.3.

I start the system using a docker-compose file that overlays a bind-mount at the data directory location;

version: '2.4'

services:
 mssql:
  image: ...
  isolation: process
  environment:
    ACCEPT_EULA: "Y"
    sa_password: ${SQL_SA_PASSWORD}
  volumes:
    - .\data\mssql:C:\Data

With above setup I had following error:

  • ssql_1 | Invoke-Sqlcmd : Cannot detach the database error when SQL server somehow was not properly shutdown (not killed)

This problem seem to be related to the VOLUME instruction in the Dockerfile (e.g.

)

When I remove the VOLUME instruction these problems (see avivasolutionsnl/sitecore-docker#49) do no longer occur.

As there is no real added value for the VOLUME instruction in the Dockerfile, e.g. volume usage can be specified in the docker-compose file, I removed the instruction for the avivasolutionsnl/sitecore-docker repo.

@pbering
Copy link
Contributor

pbering commented Feb 26, 2019

Hi there! The reason for the VOLUME in solr and sql images, was at some point to ensure data was persisted even without mounting a volume, also know as "anonymous volumes". But I would like to get rid of that to avoid polluting machines with those volumes when not using explicit volumes (mostly used for demoing and quick prototyping).

I will remove the VOLUME from solr and sql xm/xp 1803 and ltsc2019.

Thanks for helping 👍

@pbering
Copy link
Contributor

pbering commented Feb 27, 2019

Closed with 09030cb

@pbering pbering closed this as completed Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants