Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create assertions for non-strict comparison. #1

Merged
merged 7 commits into from
Jun 23, 2022

Commits on Jun 22, 2022

  1. Configuration menu
    Copy the full SHA
    c5ac5ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    142400b View commit details
    Browse the repository at this point in the history
  3. Add comparison constraint for non-strict case.

    The assert does not produce a constraint, it just stops witness
    generation. So an adversarial prover could remove the assert line and
    generate an invalid proof that the verifier would accept.
    
    Also, simplify the sourceValue === claimedValue line by removing the
    IsZero circuit.
    BlakeMScurr committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    5738112 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c2d2bec View commit details
    Browse the repository at this point in the history
  5. Fix overflow check.

    Was passing a single signal to compconstant where it required a 254 bit
    binary decomposition.
    BlakeMScurr committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    996a45a View commit details
    Browse the repository at this point in the history
  6. Revert "Import merkle tree package to fix tests."

    This reverts commit c5ac5ac.
    BlakeMScurr committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    fd23e8f View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Simplify overflow check.

    BlakeMScurr committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    c77f2a7 View commit details
    Browse the repository at this point in the history