Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGFPlotsX Support #7

Merged
merged 3 commits into from
May 13, 2020
Merged

PGFPlotsX Support #7

merged 3 commits into from
May 13, 2020

Conversation

jleugeri
Copy link
Contributor

Hi,

thanks for the awesome package(s)!

I ran accross the same issue as #4 and hacked together the minimal changes that I think need to be done to get PGFPlotsX working. It's not much, but I didn't want it to go to waste ;)

This seems to work for me™ so far, but I'm not sure I did everything correctly, particularly since PGFPlotsX.jl doesn't have a plot function or an equivalent.

So the overload feels a little.. pointless... and I'm not sure what to do with the args and kwargs. Store them in another global and pass them on for saving? Ignore them? (That's what I do now).

I also didn't touch the docs (yet).

@mykelk
Copy link
Member

mykelk commented May 12, 2020

This looks great! Thanks for doing this. Is it possible to change it so that it uses \immediate\openoutputfile{#1.tex}{juliaplot} and a similar command for closing as done for the pgfplots.jl version? This seems to help with very long documents that open many files. I think this is a minor change. Do you want to add the documentation to this PR as well? I think lots of people will find this useful.

@jleugeri
Copy link
Contributor Author

jleugeri commented May 13, 2020

Is it possible to change it so that it uses \immediate\openoutputfile{#1.tex}{juliaplot}

Sure thing, I honestly don't remember where the difference even came from - and that was yesterday 😅 I'm not much of a LaTeX crack, so I hope this makes sense now?

Since PGFPlotsX doesn't have the same level of abstraction as the other "backends" and the example code would't work like that, I added the code-example for PGFPlotsx in the README - feel free to throw it out, if you want to keep it brief.


PS: 💡 I think I edited an older version of this repo pulled in as a submodule from the tufte_algorithms_book and when I forked the repo for a PR, it merged in your later commit that switched to \openoutputfile, therefore the discrepancy between the PGFPlotsX and PGFPlots codes! Mystery solved, case closed.

@mykelk mykelk merged commit 4685709 into sisl:master May 13, 2020
@mykelk
Copy link
Member

mykelk commented May 13, 2020

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants