up

sisk-http · Nov 21, 2024 · bd9de43 · bd9de43
1 parent 0f6e893
commit bd9de43
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/extensions/Sisk.Helpers.mitmproxy/MitmproxyProvider.cs b/extensions/Sisk.Helpers.mitmproxy/MitmproxyProvider.cs
@@ -18,6 +18,9 @@ namespace Sisk.Helpers.Mitmproxy;
 /// </summary>
 public sealed class MitmproxyProvider : HttpServerHandler
 {
+    private ChildProcessStartInfo MitmdumpProcessInfo = null!;
+    private readonly Action<ChildProcessStartInfo>? setupAction;
+
     /// <summary>
     /// Gets the <see cref="IChildProcess"/> instance of the mitmdump process.
     /// </summary>
@@ -33,9 +36,6 @@ public sealed class MitmproxyProvider : HttpServerHandler
     /// </summary>
     public bool Silent { get; set; }
 
-    private ChildProcessStartInfo MitmdumpProcessInfo = null!;
-    private readonly Action<ChildProcessStartInfo>? setupAction;
-
     /// <summary>
     /// Initializes a new instance of the <see cref="MitmproxyProvider"/> class.
     /// </summary>

diff --git a/extensions/Sisk.SslProxy/CertificateUtil.cs b/extensions/Sisk.SslProxy/CertificateUtil.cs
@@ -55,7 +55,7 @@ static int ComputeArrayHash(string[] array)
     /// to the local user's certificate store.
     /// </summary>
     /// <param name="dnsNames">The certificate DNS names.</param>
-    public static X509Certificate2 CreateTrustedDevelopmentCertificate(string[] dnsNames)
+    public static X509Certificate2 CreateTrustedDevelopmentCertificate(params string[] dnsNames)
     {
         X509Certificate2 x509Certificate2;
         using (var store = new X509Store(StoreName.Root, StoreLocation.CurrentUser))
@@ -103,7 +103,7 @@ public static X509Certificate2 CreateDevelopmentCertificate(string[] dnsNames)
                 sanBuilder.Build());
 
             var certificate = request.CreateSelfSigned(new DateTimeOffset(DateTime.UtcNow.AddDays(-1)), new DateTimeOffset(DateTime.UtcNow.AddDays(3650)));
-            return new X509Certificate2(certificate.Export(X509ContentType.Pfx, "sisk"), "sisk", X509KeyStorageFlags.MachineKeySet);
+            return new X509Certificate2(certificate.Export(X509ContentType.Pfx, "sisk"), "sisk", X509KeyStorageFlags.DefaultKeySet);
         }
     }
 }
diff --git a/extensions/Sisk.SslProxy/SslProxy.cs b/extensions/Sisk.SslProxy/SslProxy.cs
@@ -21,7 +21,6 @@ namespace Sisk.Ssl;
 /// </summary>
 public sealed class SslProxy : IDisposable
 {
-    private readonly static Random clientIdGenerator = new Random();
     private readonly TcpListener listener;
     private readonly IPEndPoint remoteEndpoint;
     private readonly Channel<TcpClient> clientQueue;