Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement #290 (Sisimai::Rhost Improvement) #291

Merged
merged 15 commits into from
Jun 3, 2024
Merged

Implement #290 (Sisimai::Rhost Improvement) #291

merged 15 commits into from
Jun 3, 2024

Conversation

azumakuniyuki
Copy link
Member

@azumakuniyuki
Add a blank line
d453d0f
@azumakuniyuki
returns an empty string when the value of "diagnosticcode" is empty o…
969c856 
…r the value of "rhostclass" is empty #290
@azumakuniyuki
#290 Tiny code improvement in Sisimai::Rhost::Apple
0041291
@azumakuniyuki
#290 Update the error code list in Sisimai::Rhost::Cox
0bbaeb7
@azumakuniyuki
#290 Update the error code list in Sisimai::Rhost::FrancePTT
9c2393a
@azumakuniyuki
#290 Update the error code list in Sisimai::Rhost::GoDaddy
f1b7fa5
@azumakuniyuki
#290 Tiny code improvement in Sisimai::Rhost::Google
d60b11d
@azumakuniyuki
Use https #290
40ec18b
@azumakuniyuki
#290 Each error message should be compared with the lowercased string
8f64692
@azumakuniyuki
Tiny code improvement in Sisimai::Rhost::Microsoft #290
78bb242
@azumakuniyuki
#290 Update the error code list in Sisimai::Rhost::Mimecast
6672b24
@azumakuniyuki
#290 Update the error code list in Sisimai::Rhost::Spectrum
ad7da45
@azumakuniyuki
#290 Update the error code list in Sisimai::Rhost::Tencent
7873f14
@azumakuniyuki
Tiny code improvement in Sisimai::Rhost::YahooInc #290
308b990
@azumakuniyuki
Update the test code #290
438276c
@azumakuniyuki azumakuniyuki added improvement mta-module Modules in Sisimai::Lhost or Sisimai::RHost labels Jun 3, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 82.14286% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 94.90%. Comparing base (79b4feb) to head (438276c).

Files Patch % Lines
lib/sisimai/rhost/franceptt.rb 36.36% 7 Missing ⚠️
lib/sisimai/rhost/spectrum.rb 77.77% 2 Missing ⚠️
lib/sisimai/rhost/cox.rb 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           5-stable     #291      +/-   ##
============================================
- Coverage     95.04%   94.90%   -0.15%     
============================================
  Files           134      134              
  Lines          6826     6830       +4     
============================================
- Hits           6488     6482       -6     
- Misses          338      348      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azumakuniyuki azumakuniyuki merged commit 3534c29 into 5-stable Jun 3, 2024
5 of 7 checks passed
azumakuniyuki added a commit that referenced this pull request Jun 4, 2024
@azumakuniyuki
Update the release notes #290 #291
a5c9272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement mta-module Modules in Sisimai::Lhost or Sisimai::RHost
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@azumakuniyuki