core: add DisableHTMLEscape flag to json_formatter #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any plans on getting this fixed and merged in to the master? |
|
Any update on this issues? |
|
I can't really do anything here, since the CI needs to be adjusted to drop go 1.6 support for the tests to pass. The library seems to be abandoned though :( |
|
@dgsb @igorsechyn CI now drops support for 1.6.. Can this PR be merged?(after resolve conflict) |
|
bump for this issue. would be really nice to have this. we are at go 1.13 now btw. |
|
@igorsechyn Any interest in rebasing this PR? |
|
some news? |
|
made a pull request that resolved conflicts here: |
markphelps
added a commit
that referenced
this pull request
Mar 22, 2020
resolved conflicts for DisableHTMLEscape in json_formatter.go pull request #524
|
Fixed in #1113. Thank you @igorsechyn ! |
This was referenced Mar 10, 2021
Closed
This was referenced May 21, 2021
This was referenced Jun 6, 2021
Closed
1 task
cgxxv
pushed a commit
to cgxxv/logrus
that referenced
this pull request
Mar 25, 2022
resolved conflicts for DisableHTMLEscape in json_formatter.go pull request sirupsen#524
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable logging URLs with special characters like "&" and "%".
HTML escaping support was only however added in go 1.7, so it is not compatible with 1.6 :(