Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: update for php-coveralls 2.6.0 #303

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Jul 16, 2023

PHP-Coveralls 2.6.0 has just been released and includes a fix for the last known PHP 8.x issue.

This means that it should now be safe to install php-coveralls on PHP 8.x and upload from there, which means we now only need the work-around for the PHP version when on PHP < 5.5 (as Coveralls v1 does not work with GH Actions).

Ref:

@jrfnl
Copy link
Collaborator Author

jrfnl commented Jul 16, 2023

Note: the build will fail until PR #304 has been merged. After that, this PR should be rebased to get a passing build.

@sirbrillig
Copy link
Owner

#304 has been merged.

PHP-Coveralls 2.6.0 has just been released and includes a fix for the last known PHP 8.x issue.

This means that it should now be safe to install php-coveralls on PHP 8.x and upload from there, which means we now only need the work-around for the PHP version when on PHP < 5.5 (as Coveralls v1 does not work with GH Actions).

Ref:
* https://github.com/php-coveralls/php-coveralls/releases/tag/v2.6.0
@jrfnl jrfnl force-pushed the feature/ghactions-upgrade-php-coveralls-2.6.0 branch from 65cd50a to 03ca6ef Compare July 19, 2023 00:21
@jrfnl
Copy link
Collaborator Author

jrfnl commented Jul 19, 2023

Rebased!

@sirbrillig sirbrillig merged commit 002ae3a into 2.x Jul 19, 2023
@sirbrillig sirbrillig deleted the feature/ghactions-upgrade-php-coveralls-2.6.0 branch July 19, 2023 00:44
@sirbrillig
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants