Dns bootstrap during iso install #269
Merged
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celskeggs
requested changes
Mar 11, 2018
| config = configuration.get_config() | ||
| return ["%s\t%s # AUTO-HOMEWORLD-BOOTSTRAP" % (ip, hostname) for hostname, ip in config.dns_bootstrap.items()] | ||
|
|
||
|
|
There was a problem hiding this comment.
Have you removed setup_dns_bootstrap from the cluster init sequence? You probably should.
|
Also, this should probably be rebased into a single commit. But this is almost ready to merge! (Remember to assign this back to me when you're done making corrections.) |
minced
force-pushed
the
dns-bootstrap-during-iso-install
branch
from
f3e2f6f to
73dadc4
Compare
celskeggs
approved these changes
Mar 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested changes by bouncing the cluster with the "normal" DNS bootstrap code
ops.add_subcommand(setup.setup_dns_bootstrap)commented out in seq.py.