Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract string constants from SemverOut so they can be reused #380

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

guillermocalvo
Copy link
Collaborator

According to Sonar rules:

Duplicated string literals make the process of refactoring complex and error-prone, as any change would need to be propagated on all occurrences.

The rationale behind this PR is that I'm working on a new output generator for japicmp that would benefit from SemverOut results being defined as constants.

@siom79 siom79 merged commit af2152a into siom79:master Feb 18, 2024
6 checks passed
@guillermocalvo guillermocalvo deleted the extract-semver-constants branch February 18, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants