Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds minification to vanilla CSS and HTML #125

Open
wants to merge 4 commits into
base: release-v1.0.0
Choose a base branch
from

Conversation

kennethormandy
Copy link
Collaborator

  • Adds consistent CSS minification to vanilla CSS files
  • Adds consistent minification to HTML files

The HTML one still has one failing test I’m not sure about:

  1) render(path, callback) plain should fire callback when:
     AssertionError: expected '<h1>Just a plain old html file.</h1>' to not exist
    at test/render.js:129:20
    at Object.render (lib/terraform.js:143:11)
    at Context.<anonymous> (test/render.js:128:12)

@kennethormandy kennethormandy mentioned this pull request Jan 8, 2016
6 tasks
kennethormandy added a commit to sintaxi/harp that referenced this pull request Jan 12, 2016
Revert this commit once we merge
sintaxi/terraform#125
@lunelson
Copy link
Contributor

@kennethormandy is there any chance minification is, or could be, dependent on the ENVIRONMENT variable? I use Harp for prototyping and my HTML output is often copy-pasted over to PHP development, so currently I've disabled minification in my own fork but a development/production flag would be cool cause obviously server-side it should be minified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants