Macro support #381
Open
Macro support #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var loadMacros = function(projectPath) { | ||
| var macros = {} | ||
| var macroDir = path.join(projectPath, "_macros/") | ||
| if (!fs.existsSync(macroDir)) { |
There was a problem hiding this comment.
You should not look if it exists, you should just try to read it and then catch the error there, now your are essential reading the dir twice.
There was a problem hiding this comment.
I tend to avoid try/catch based programming, but I understand your point about performance. I can change that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the concept of macro (maybe it can be named something more meaningful).
Applications built with harp can include a
_macrosfolder in the project root and add node.js modules into this folder. Functions and objects exported by modules will be available in the global scope and accessible from templates asThis helps keeping code/logic out of templates and avoid code like http://harpjs.com/recipes/blog-sitemap.
It opens up harp to lots of freedom for more expert developers who want a more customized harp experience.