Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for handlebars templates #246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

trevex
Copy link

@trevex trevex commented Feb 13, 2014

Necessary changes to support handlebar templates using changes introduces by sintaxi/terraform#36

As requested by #60

@kennethormandy kennethormandy added this to the Handlebars support milestone Mar 28, 2014
@ixley
Copy link

ixley commented Apr 15, 2014

what's the status of this?

@kennethormandy
Copy link
Collaborator

Sorry for the silence on it. We have one technical issue and one non-technical issues.

The former is that the pull request had no tests. I wrote the tests and some aren’t passing. While EJS and Jade make it relatively easy to add the custom partial() function, this isn’t present in that PR.

The non-technical issue is that we feel like we need to document everything that is build into Harp. Ideally we’d have the language system (#209) done so Handlebars would be an additional install or we’d move Handlebars into core and move EJS out. This requirement might be debatable, though. Personally if someone else took care of the first issue, I’d be fine with adding more docs since I think Handlebars would make people happy.

@cfjedimaster
Copy link

Speaking for myself, and just on the 2nd issue, I don't think you guys need
to handle documenting every feature in every possible language. I believe
your end goal is to get to a point where folks can drop in Language X and
have it work, so it wouldn't even be possible to document everything. (Now,
personally, I think Handlebars is a nicer language than Jade or EJS, so I'd
drop EJS and show Handlebars, but you get my point in general).

On Tue, Apr 15, 2014 at 2:55 PM, Kenneth Ormandy
[email protected]:

Sorry for the silence on it. We have one technical issue and one
non-technical issues.

The former is that the pull request had no tests. I wrote the tests and
some aren’t passinghttps://github.com/kennethormandy/terraform/tree/release-v0.7.1.
While EJS and Jade make it relatively easy to add the custom partial()function, this isn’t present in that PR.

The non-technical issue is that we feel like we need to document
everything that is build into Harp. Ideally we’d have the language system (
#209 #209) done so Handlebars
would be an additional install or we’d move Handlebars into core and move
EJS out. This requirement might be debatable, though. Personally if someone
else took care of the first issue, I’d be fine with adding more docs since
I think Handlebars would make people happy.


Reply to this email directly or view it on GitHubhttps://github.com//pull/246#issuecomment-40526442
.

Raymond Camden, Web Developer for Adobe

Email : [email protected]
Blog : www.raymondcamden.com
Twitter: raymondcamden

@ixley
Copy link

ixley commented Apr 15, 2014

To me, a language system that allows others to author plugins seems like a great direction. Harp's flexibility is one of the things that appealed to me in the first place when surveying different tools.
I also agree with @cfjedimaster about prioritizing making a tool that's extensible/flexible (on top of being easy to understand - i.e. well-documented).

@zeke
Copy link
Contributor

zeke commented Jul 6, 2014

I'd like to give this handlebars branch a try. Is @trevex or anyone actually using it?

@kennethormandy
Copy link
Collaborator

@zeke I took it as far as I could, there were no tests so I added them here. I got stuck when I realised partial() would need to be implemented though, so two basic tests for that are still failing.

@sintaxi sintaxi removed this from the Handlebars support milestone Mar 2, 2015
@fabalca
Copy link

fabalca commented Feb 3, 2016

any new word on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants