-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TypeError under Python 3.5 #4
Conversation
Theoretically we should adjust the CI, etc. so that we test against Python 3.5 as well. But from a quick first try, seems like it would bring other breakages (with pytest-yapf3). But since the code change is so small maybe we could simply take the change without advertising Python 3.5 compatibility. It would be compatible by coincidence. |
Since I host the code on both GitHub and GitLab (and who knows where the code will land later on), I want to have elements of the commit messages that refer to a specific platform prefixed accordingly. It makes things clearer anyway. Something like:
Would you mind doing that? |
Github: fixes #3
Of course, done. :) |
Perhaps you could exclude the yapf checks for the 3.5 run. Side note: I look forward to not using 3.5 myself and not caring about this. :D But for the moment, you know, constraints. |
Thanks.
Yes. I have been meaning to revamp the whole thing for a while now, since there is no reason to do the whole linting, typing, formatting, etc. for each Python version (sometimes they even contradict each other). Once it's done, I will think about activating Python 3.5 in the CI.
I get it. If it is truly needed then I will try to get the change in and publish a new release quickly. |
Many thanks! |
Fixes #3