-
-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-introduce new version script #2438
Conversation
This was inadvertently removed during merge conflicts, and is required for any of the new release process stuff to work
Otherwise this is just gonna keep popping up
Codecov Report
@@ Coverage Diff @@
## master #2438 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 41 41
Lines 1906 1906
=======================================
Hits 1830 1830
Misses 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@fatso83 Okay, I ran through and simulated a clean merge of #2426 to make sure the end-result of all of this merging was the same as if things had gone more smoothly, and this was the only remaining difference I found. I also snuck in the prettier change, and had a related question - do you have some sort of extra config for |
@cincodenada Yeah, I manually deleted all I regarded as noise for people browsing the changelog. |
@@ -4,6 +4,7 @@ layout: default | |||
title: Changelog | |||
permalink: /releases/changelog | |||
--- | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. Was not sure where that came from (not that I was looking 😛 ).
Purpose (TL;DR)
Because of the merge mess with #2426, the
version
command inpackage.json
was reverted, so that the newversion.sh
script isn't being used.Solution
This PR also puts the
version.sh
script back, and persists a prettier fix in a generated file back to the generation of the file, so it doesn't keep popping up.How to verify - mandatory
The only way to really, test this is to run
npm version
, but if #2436 is merged first, then we'll have a way to run that without publishing a release!Checklist for author
npm run lint
passes