Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(#1887) #1918

Merged
merged 2 commits into from
Oct 7, 2018
Merged

test(#1887) #1918

merged 2 commits into from
Oct 7, 2018

Conversation

mgred
Copy link
Contributor

@mgred mgred commented Oct 6, 2018 •
edited
Loading

Purpose (TL;DR) - mandatory

This adds the test case described in #1887

Background

As of the issue the test fails for 6.1.3 and above.

Solution

Testing this with version 6.3.5 (node 6.9.5), the test passes

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm run test-node

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@mgred mgred requested a review from mroderick October 6, 2018 21:10
@mgred mgred changed the title Sinon/1887 test(#1887) Oct 6, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2701

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.356%
Totals Coverage Status
Change from base Build 2700: 0.0%
Covered Lines: 2043
Relevant Lines: 2097
💛 - Coveralls

@mroderick mroderick merged commit eae7d4a into sinonjs:master Oct 7, 2018
@mroderick
Copy link
Member

Nice 👍

@mroderick mroderick mentioned this pull request Dec 8, 2018
Closed
franck-romano pushed a commit to franck-romano/sinon that referenced this pull request Oct 1, 2019
@mgred
test(sinonjs#1887) (sinonjs#1918)
08d7540 
* test(sinonjs#1887): add test

Adding the test case described in sinonjs#1887

* test(sinonjs#1887): set test title according to issue title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroderick mroderick Awaiting requested review from mroderick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgred @coveralls @mroderick