Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#304] syncing QE with the new Atom DB #313

Merged
merged 5 commits into from
Aug 14, 2024

Conversation

angeloprobst
Copy link
Collaborator

Closes #304

Making das-query-engine compatible with the new das-atom-db.

hyperon_das/das.py Outdated Show resolved Hide resolved
hyperon_das/das.py Outdated Show resolved Hide resolved
hyperon_das/das.py Outdated Show resolved Hide resolved
hyperon_das/query_engines/local_query_engine.py Outdated Show resolved Hide resolved
hyperon_das/query_engines/local_query_engine.py Outdated Show resolved Hide resolved
tests/unit/mock.py Outdated Show resolved Hide resolved
hyperon_das/cache/iterators.py Outdated Show resolved Hide resolved
@andre-senna
Copy link
Contributor

@angeloprobst

I revisited the code in this branch checking the way we use parameters down the line after DAS.query() is called.

parameters: Optional[Dict[str, Any]] = None,

IMO we should remove Optional and default parameters to {} in this declaration and in the declarations of concrete query engine's query() as well because we could avoid checks for None which are just making the code less clear.

@angeloprobst
Copy link
Collaborator Author

IMO we should remove Optional and default parameters to {}

Done.

@angeloprobst angeloprobst merged commit 98ab908 into master Aug 14, 2024
1 of 4 checks passed
@angeloprobst angeloprobst deleted the angelo/#304/syncing-QE-with-new-AtomDB branch August 14, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync das-query-engine with das-atom-db after refactoring work
3 participants