pytorch tensor truth value #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsbogd
reviewed
Apr 16, 2019
| ADD_LIBRARY (truthvalue | ||
| CountTruthValue.cc | ||
| EvidenceCountTruthValue.cc | ||
| FuzzyTruthValue.cc | ||
| IndefiniteTruthValue.cc | ||
| ProbabilisticTruthValue.cc | ||
| SimpleTruthValue.cc | ||
| TruthValue.cc | ||
| TruthValue.cc |
| @@ -32,6 +32,7 @@ INDEFINITE_TRUTH_VALUE <- TRUTH_VALUE | |||
| FUZZY_TRUTH_VALUE <- TRUTH_VALUE | |||
| PROBABILISTIC_TRUTH_VALUE <- TRUTH_VALUE | |||
| EVIDENCE_COUNT_TRUTH_VALUE <- TRUTH_VALUE | |||
| TTRUTH_VALUE <- TRUTH_VALUE "TTruthValue" | |||
There was a problem hiding this comment.
I suggest name it TORCH_TRUTH_VALUE as TTRUTH_VALUE is unclear and ambiguous - usually T at the beginning sounds as Type. And rename TTruthValue to TorchTruthValue as well for clarity.
Co-Authored-By: noskill <[email protected]>
Co-Authored-By: noskill <[email protected]>
vsbogd
reviewed
Apr 16, 2019
| from opencog.atomspace import TensorTruthValue | ||
| from torch import tensor | ||
| import torch | ||
| TTruthValue = TensorTruthValue |
There was a problem hiding this comment.
Why did you not renamed classes in test? As test can be used as example of code it can be misleading.
There was a problem hiding this comment.
I don't see misleading class names in this file. Which one looks misleading to you?
This was referenced Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapper truth value class for python object.
TTruthValue c++ class wraps pytorch tensor object to query for mean and confidence, so that it can be accessed from both c++ and python.
see issue singnet/opencog#70